[fix](cloud) use snapshot read for table version to avoid txn conflict (#64647)#66068
Open
deardeng wants to merge 1 commit into
Open
[fix](cloud) use snapshot read for table version to avoid txn conflict (#64647)#66068deardeng wants to merge 1 commit into
deardeng wants to merge 1 commit into
Conversation
apache#64647) PR apache#60467 added a non-snapshot txn->get(table_version_key) in commit_txn, commit_partition, commit_index and drop_partition to return table_version+1 to FE as a version-cache hint. A non-snapshot read adds table_version_key to the transaction's read-conflict range, while update_table_version() bumps the same key via atomic_add (otherwise conflict-free). As a result, concurrent commits/imports on the same table now conflict on the version key and fail with KV_TXN_CONFLICT, causing retries and throughput regression. Change these reads to snapshot reads. The returned value is only a hint for FE's version cache (reconciled by CloudTableAndPartitionVersionChecker) and the real increment is still done by atomic_add, so correctness is preserved while the read-conflict on the version key is removed. (cherry picked from commit 64df172)
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #64647
PR #60467 added a non-snapshot txn->get(table_version_key) in commit_txn, commit_partition, commit_index and drop_partition to return table_version+1 to FE as a version-cache hint. A non-snapshot read adds table_version_key to the transaction's read-conflict range, while update_table_version() bumps the same key via atomic_add (otherwise conflict-free). As a result, concurrent commits/imports on the same table now conflict on the version key and fail with KV_TXN_CONFLICT, causing retries and throughput regression.
Change these reads to snapshot reads. The returned value is only a hint for FE's version cache (reconciled by
CloudTableAndPartitionVersionChecker) and the real increment is still done by atomic_add, so correctness is preserved while the read-conflict on the version key is removed.
(cherry picked from commit 64df172)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)