Skip to content

[fix](row binlog): op should be insert but update when insert after delete#66046

Open
Userwhite wants to merge 2 commits into
apache:masterfrom
Userwhite:fix_insert_after_delete
Open

[fix](row binlog): op should be insert but update when insert after delete#66046
Userwhite wants to merge 2 commits into
apache:masterfrom
Userwhite:fix_insert_after_delete

Conversation

@Userwhite

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #65808

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Userwhite

Copy link
Copy Markdown
Contributor Author

/review

@Userwhite

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29756 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6fde9ee23fb09ce05bd9f7027f54764f2538d8be, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17663	4086	4083	4083
q2	2007	336	194	194
q3	10295	1455	843	843
q4	4679	477	346	346
q5	7511	860	568	568
q6	187	171	141	141
q7	762	854	627	627
q8	9842	1684	1530	1530
q9	6129	4309	4329	4309
q10	6827	1780	1495	1495
q11	500	358	334	334
q12	758	581	450	450
q13	18186	3438	2736	2736
q14	271	256	248	248
q15	q16	797	784	716	716
q17	978	960	994	960
q18	6860	5756	5630	5630
q19	1169	1275	1056	1056
q20	811	681	621	621
q21	5761	2673	2567	2567
q22	427	351	302	302
Total cold run time: 102420 ms
Total hot run time: 29756 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4418	4444	4501	4444
q2	287	317	207	207
q3	4568	4987	4452	4452
q4	2041	2164	1397	1397
q5	4453	4384	4303	4303
q6	221	178	127	127
q7	2008	1972	1673	1673
q8	2538	2148	2115	2115
q9	7870	7907	7734	7734
q10	4722	4624	4235	4235
q11	587	413	390	390
q12	950	763	538	538
q13	3328	3558	3014	3014
q14	299	314	286	286
q15	q16	743	744	657	657
q17	1324	1390	1338	1338
q18	7997	7446	7011	7011
q19	1124	1101	1095	1095
q20	2234	2220	1941	1941
q21	5298	4595	4404	4404
q22	520	463	394	394
Total cold run time: 57530 ms
Total hot run time: 51755 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 177500 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6fde9ee23fb09ce05bd9f7027f54764f2538d8be, data reload: false

query5	4324	652	492	492
query6	470	239	229	229
query7	4870	581	333	333
query8	338	192	194	192
query9	8800	4145	4125	4125
query10	454	378	288	288
query11	5963	2349	2114	2114
query12	165	109	103	103
query13	1272	637	454	454
query14	6218	5242	4900	4900
query14_1	4248	4266	4232	4232
query15	220	211	181	181
query16	1041	469	461	461
query17	1122	723	579	579
query18	2506	463	357	357
query19	210	194	150	150
query20	116	111	107	107
query21	236	162	139	139
query22	13491	13503	13279	13279
query23	17520	16610	16135	16135
query23_1	16309	16313	16329	16313
query24	7466	1745	1279	1279
query24_1	1306	1292	1279	1279
query25	562	464	390	390
query26	1339	349	220	220
query27	2583	579	376	376
query28	4440	1982	1998	1982
query29	1074	618	503	503
query30	344	271	228	228
query31	1153	1084	972	972
query32	102	66	60	60
query33	527	309	248	248
query34	1183	1140	656	656
query35	762	792	667	667
query36	1199	1191	1026	1026
query37	159	113	96	96
query38	1881	1708	1674	1674
query39	899	866	852	852
query39_1	817	836	839	836
query40	257	179	160	160
query41	65	62	62	62
query42	93	98	98	98
query43	329	332	280	280
query44	1413	762	779	762
query45	188	178	172	172
query46	1056	1166	698	698
query47	2165	2135	2032	2032
query48	394	427	290	290
query49	576	418	338	338
query50	1069	442	331	331
query51	10737	10398	10752	10398
query52	86	88	76	76
query53	264	284	199	199
query54	275	233	218	218
query55	73	74	67	67
query56	308	308	291	291
query57	1322	1287	1215	1215
query58	266	262	249	249
query59	1567	1666	1469	1469
query60	309	271	252	252
query61	151	151	154	151
query62	543	498	432	432
query63	239	203	201	201
query64	2796	1103	871	871
query65	4735	4631	4597	4597
query66	1801	513	384	384
query67	29691	29226	29099	29099
query68	3091	1590	1057	1057
query69	412	301	264	264
query70	1066	968	951	951
query71	365	345	302	302
query72	3090	2691	2383	2383
query73	807	755	452	452
query74	5085	4907	4729	4729
query75	2538	2504	2137	2137
query76	2328	1164	774	774
query77	359	387	279	279
query78	11810	11933	11313	11313
query79	1358	1207	745	745
query80	1228	539	455	455
query81	515	338	294	294
query82	589	159	117	117
query83	417	328	299	299
query84	282	162	133	133
query85	982	638	537	537
query86	395	294	274	274
query87	1832	1823	1771	1771
query88	3724	2815	2781	2781
query89	438	377	325	325
query90	1817	204	204	204
query91	202	191	160	160
query92	65	58	54	54
query93	1488	1485	1021	1021
query94	642	361	335	335
query95	805	486	565	486
query96	1056	823	352	352
query97	2645	2667	2492	2492
query98	212	206	199	199
query99	1093	1116	974	974
Total cold run time: 263475 ms
Total hot run time: 177500 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.02 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6fde9ee23fb09ce05bd9f7027f54764f2538d8be, data reload: false

query1	0.00	0.00	0.00
query2	0.09	0.05	0.05
query3	0.25	0.14	0.13
query4	1.61	0.13	0.13
query5	0.24	0.22	0.22
query6	1.23	1.06	1.14
query7	0.04	0.00	0.00
query8	0.06	0.04	0.04
query9	0.38	0.30	0.31
query10	0.54	0.55	0.56
query11	0.20	0.14	0.13
query12	0.18	0.14	0.14
query13	0.46	0.48	0.47
query14	1.02	1.00	0.99
query15	0.61	0.61	0.60
query16	0.32	0.31	0.31
query17	1.08	1.08	1.12
query18	0.22	0.22	0.21
query19	2.05	2.01	1.93
query20	0.02	0.02	0.02
query21	15.43	0.22	0.13
query22	4.75	0.05	0.06
query23	16.13	0.31	0.13
query24	2.96	0.42	0.32
query25	0.10	0.04	0.06
query26	0.74	0.20	0.15
query27	0.04	0.04	0.03
query28	3.52	0.86	0.53
query29	12.52	4.12	3.28
query30	0.27	0.16	0.17
query31	2.78	0.61	0.31
query32	3.22	0.58	0.47
query33	3.16	3.23	3.26
query34	15.73	4.23	3.53
query35	3.54	3.52	3.53
query36	0.56	0.44	0.41
query37	0.08	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.03	0.03
query40	0.19	0.17	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.56 s
Total hot run time: 25.02 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 46.03% (29/63) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.29% (31073/41271)
Line Coverage 59.82% (346108/578554)
Region Coverage 56.51% (290607/514255)
Branch Coverage 57.89% (129904/224414)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] MIN_DELTA stream emits UPDATE_BEFORE/UPDATE_AFTER when reinserting a deleted MOW key

2 participants