Skip to content

[opt](build) use mvn to compile thrift for fe#61486

Open
morrySnow wants to merge 1 commit intoapache:masterfrom
morrySnow:compile_thrift
Open

[opt](build) use mvn to compile thrift for fe#61486
morrySnow wants to merge 1 commit intoapache:masterfrom
morrySnow:compile_thrift

Conversation

@morrySnow
Copy link
Contributor

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 18, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (19778/37531)
Line Coverage 36.24% (184756/509851)
Region Coverage 32.50% (143087/440216)
Branch Coverage 33.65% (62524/185783)

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 26970 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5694fdf106f2294fafb4c0981dca6b666fe39235, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	16517	4434	4288	4288
q2	q3	10194	775	570	570
q4	4539	360	254	254
q5	7511	1221	1049	1049
q6	180	177	148	148
q7	802	858	685	685
q8	9410	1510	1387	1387
q9	4895	4722	4636	4636
q10	6248	1913	1632	1632
q11	469	261	243	243
q12	717	582	484	484
q13	18043	2985	2172	2172
q14	236	237	213	213
q15	q16	728	744	673	673
q17	731	841	470	470
q18	5893	5324	5317	5317
q19	1108	988	639	639
q20	538	508	383	383
q21	4448	1850	1476	1476
q22	346	296	251	251
Total cold run time: 93553 ms
Total hot run time: 26970 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4951	4739	4582	4582
q2	q3	3876	4330	3824	3824
q4	930	1240	778	778
q5	4087	4411	4334	4334
q6	191	183	140	140
q7	1796	1670	1557	1557
q8	2532	2792	2574	2574
q9	7716	7354	7385	7354
q10	3833	4021	3614	3614
q11	527	452	426	426
q12	527	596	444	444
q13	2692	3203	2459	2459
q14	280	304	281	281
q15	q16	731	774	714	714
q17	1455	1382	1326	1326
q18	7090	6747	6670	6670
q19	939	918	1138	918
q20	2105	2174	1994	1994
q21	4046	3493	3348	3348
q22	456	417	378	378
Total cold run time: 50760 ms
Total hot run time: 47715 ms

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.37% (32268/50130)
Region Coverage 65.27% (16162/24760)
Branch Coverage 55.68% (8606/15456)

@doris-robot
Copy link

TPC-DS: Total hot run time: 168951 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5694fdf106f2294fafb4c0981dca6b666fe39235, data reload: false

query5	4342	666	523	523
query6	359	260	217	217
query7	4220	496	284	284
query8	361	256	232	232
query9	8729	2753	2734	2734
query10	541	403	359	359
query11	6979	5086	4900	4900
query12	188	131	125	125
query13	1283	479	344	344
query14	5709	3777	3518	3518
query14_1	2905	2861	2841	2841
query15	208	199	177	177
query16	1018	480	468	468
query17	1127	750	638	638
query18	2548	458	367	367
query19	219	216	193	193
query20	150	127	133	127
query21	221	134	115	115
query22	13307	14026	14743	14026
query23	16172	15647	15574	15574
query23_1	15889	15804	15488	15488
query24	7014	1634	1231	1231
query24_1	1248	1285	1229	1229
query25	534	460	420	420
query26	1252	260	153	153
query27	2759	483	301	301
query28	4333	1834	1850	1834
query29	828	571	487	487
query30	302	235	192	192
query31	1017	966	881	881
query32	78	74	70	70
query33	523	328	308	308
query34	892	879	550	550
query35	645	677	595	595
query36	1081	1206	946	946
query37	135	92	86	86
query38	2945	2929	2818	2818
query39	847	839	816	816
query39_1	799	805	786	786
query40	232	155	137	137
query41	63	61	60	60
query42	263	251	262	251
query43	242	259	227	227
query44	
query45	204	192	184	184
query46	884	989	621	621
query47	2092	2140	2043	2043
query48	314	316	244	244
query49	659	460	405	405
query50	714	282	219	219
query51	4085	4057	4043	4043
query52	264	268	257	257
query53	295	333	285	285
query54	306	278	271	271
query55	93	87	85	85
query56	315	333	325	325
query57	1962	1853	1746	1746
query58	295	278	276	276
query59	2791	2967	2788	2788
query60	351	349	338	338
query61	164	156	164	156
query62	644	616	539	539
query63	315	275	286	275
query64	4810	1311	1019	1019
query65	
query66	1443	462	384	384
query67	24254	24519	24369	24369
query68	
query69	418	322	286	286
query70	989	920	973	920
query71	348	314	307	307
query72	2841	2689	2488	2488
query73	545	547	325	325
query74	9641	9565	9408	9408
query75	2869	2768	2482	2482
query76	2049	1069	676	676
query77	370	386	314	314
query78	10915	11133	10475	10475
query79	1130	780	598	598
query80	1331	631	549	549
query81	547	262	221	221
query82	955	153	118	118
query83	338	270	251	251
query84	255	116	106	106
query85	940	497	468	468
query86	419	311	323	311
query87	3128	3083	3029	3029
query88	3620	2688	2667	2667
query89	431	368	348	348
query90	2079	188	179	179
query91	168	167	138	138
query92	96	79	71	71
query93	1035	854	505	505
query94	619	333	303	303
query95	604	403	322	322
query96	659	525	228	228
query97	2471	2490	2358	2358
query98	233	225	231	225
query99	1022	980	907	907
Total cold run time: 249116 ms
Total hot run time: 168951 ms

@morrySnow
Copy link
Contributor Author

run p0

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.69% (19775/37532)
Line Coverage 36.21% (184609/509870)
Region Coverage 32.47% (142948/440261)
Branch Coverage 33.65% (62520/185791)

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 26855 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5694fdf106f2294fafb4c0981dca6b666fe39235, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17689	4491	4283	4283
q2	q3	10647	764	515	515
q4	4673	355	253	253
q5	7559	1230	1024	1024
q6	178	170	146	146
q7	779	869	685	685
q8	9312	1463	1372	1372
q9	5093	4686	4643	4643
q10	6241	1950	1679	1679
q11	483	252	249	249
q12	693	578	484	484
q13	18024	2919	2182	2182
q14	225	234	209	209
q15	q16	730	717	672	672
q17	721	846	413	413
q18	5909	5502	5275	5275
q19	1113	975	609	609
q20	533	488	377	377
q21	4162	1864	1405	1405
q22	334	380	393	380
Total cold run time: 95098 ms
Total hot run time: 26855 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4761	4640	4599	4599
q2	q3	3874	4349	3850	3850
q4	871	1209	781	781
q5	4075	4426	4312	4312
q6	192	179	145	145
q7	1774	1653	1531	1531
q8	2550	2773	2539	2539
q9	7589	7337	7601	7337
q10	3803	4012	3574	3574
q11	513	428	406	406
q12	523	577	439	439
q13	2807	3173	2308	2308
q14	283	300	280	280
q15	q16	717	758	725	725
q17	1137	1274	1323	1274
q18	7192	6754	6570	6570
q19	912	1088	914	914
q20	2069	2172	2008	2008
q21	4026	3498	3301	3301
q22	436	414	388	388
Total cold run time: 50104 ms
Total hot run time: 47281 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168665 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5694fdf106f2294fafb4c0981dca6b666fe39235, data reload: false

query5	4330	633	518	518
query6	368	242	230	230
query7	4230	477	277	277
query8	357	250	249	249
query9	8753	2717	2700	2700
query10	515	391	350	350
query11	6997	5102	4894	4894
query12	183	136	130	130
query13	1287	446	341	341
query14	5765	3768	3496	3496
query14_1	2895	2869	2816	2816
query15	208	201	176	176
query16	979	474	444	444
query17	907	748	637	637
query18	2457	462	356	356
query19	218	216	219	216
query20	127	123	126	123
query21	212	128	112	112
query22	13216	13978	14694	13978
query23	16538	15999	15716	15716
query23_1	15653	15552	15406	15406
query24	7122	1638	1232	1232
query24_1	1237	1226	1222	1222
query25	535	473	402	402
query26	1236	261	146	146
query27	2784	483	297	297
query28	4458	1818	1823	1818
query29	869	568	518	518
query30	297	227	190	190
query31	1011	951	881	881
query32	79	73	70	70
query33	505	333	302	302
query34	892	871	514	514
query35	630	681	586	586
query36	1105	1137	1006	1006
query37	130	97	86	86
query38	3012	2924	2887	2887
query39	865	844	828	828
query39_1	793	790	785	785
query40	224	154	151	151
query41	63	59	57	57
query42	267	256	258	256
query43	242	258	213	213
query44	
query45	200	188	180	180
query46	880	988	612	612
query47	2116	2162	2081	2081
query48	299	303	228	228
query49	636	461	380	380
query50	684	278	213	213
query51	4105	4055	4119	4055
query52	261	274	257	257
query53	285	335	284	284
query54	302	283	260	260
query55	97	85	85	85
query56	313	343	309	309
query57	1937	1738	1651	1651
query58	290	313	268	268
query59	2821	2953	2731	2731
query60	341	339	333	333
query61	157	156	158	156
query62	629	588	537	537
query63	308	278	283	278
query64	5146	1288	979	979
query65	
query66	1470	453	357	357
query67	24193	24192	24222	24192
query68	
query69	403	309	283	283
query70	935	899	958	899
query71	336	327	288	288
query72	2812	2701	2679	2679
query73	539	548	328	328
query74	9564	9533	9371	9371
query75	2886	2797	2520	2520
query76	2296	1036	694	694
query77	388	393	308	308
query78	10956	11075	10479	10479
query79	1198	770	577	577
query80	1421	658	579	579
query81	575	272	230	230
query82	1025	156	126	126
query83	384	278	254	254
query84	305	131	101	101
query85	1038	495	455	455
query86	417	305	325	305
query87	3139	3082	3072	3072
query88	3541	2655	2642	2642
query89	435	372	344	344
query90	2006	184	172	172
query91	172	162	138	138
query92	76	79	72	72
query93	1004	847	489	489
query94	647	325	286	286
query95	602	397	320	320
query96	637	508	227	227
query97	2484	2479	2400	2400
query98	235	245	216	216
query99	1047	997	912	912
Total cold run time: 249644 ms
Total hot run time: 168665 ms

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.41% (32287/50130)
Region Coverage 65.27% (16160/24760)
Branch Coverage 55.71% (8610/15456)

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (19780/37532)
Line Coverage 36.25% (184801/509865)
Region Coverage 32.49% (143045/440261)
Branch Coverage 33.66% (62540/185793)

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 26695 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e66f2088256b4553743caec7f81bb68165025c9e, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	16573	4567	4313	4313
q2	q3	10248	752	524	524
q4	4596	363	250	250
q5	7550	1217	1013	1013
q6	178	176	151	151
q7	791	866	685	685
q8	9418	1526	1328	1328
q9	4878	4703	4709	4703
q10	6246	1916	1663	1663
q11	478	255	237	237
q12	690	588	465	465
q13	18020	2932	2170	2170
q14	230	236	222	222
q15	q16	722	756	673	673
q17	736	862	458	458
q18	6078	5475	5176	5176
q19	1121	961	604	604
q20	534	496	385	385
q21	4336	1832	1437	1437
q22	345	297	238	238
Total cold run time: 93768 ms
Total hot run time: 26695 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4957	4687	4689	4687
q2	q3	3942	4329	3854	3854
q4	893	1181	802	802
q5	4093	4409	4401	4401
q6	191	182	140	140
q7	1783	1646	1539	1539
q8	2489	2762	2539	2539
q9	7472	7439	7283	7283
q10	3822	4003	3627	3627
q11	521	428	417	417
q12	508	615	464	464
q13	2772	3282	2589	2589
q14	294	303	286	286
q15	q16	725	782	723	723
q17	1233	1355	1308	1308
q18	7342	6970	6629	6629
q19	886	925	940	925
q20	2053	2189	2027	2027
q21	3954	3518	3356	3356
q22	456	446	392	392
Total cold run time: 50386 ms
Total hot run time: 47988 ms

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 78.63% (1796/2284)
Line Coverage 64.40% (32283/50130)
Region Coverage 65.28% (16163/24760)
Branch Coverage 55.71% (8611/15456)

@doris-robot
Copy link

TPC-DS: Total hot run time: 169274 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e66f2088256b4553743caec7f81bb68165025c9e, data reload: false

query5	4332	653	524	524
query6	331	235	219	219
query7	4212	477	272	272
query8	344	239	227	227
query9	8713	2717	2728	2717
query10	538	396	349	349
query11	6951	5108	4876	4876
query12	174	134	138	134
query13	1264	461	360	360
query14	5746	3713	3473	3473
query14_1	2844	2890	2807	2807
query15	204	192	186	186
query16	969	468	440	440
query17	854	705	632	632
query18	2429	447	346	346
query19	217	207	191	191
query20	133	127	125	125
query21	217	136	107	107
query22	13301	14091	14500	14091
query23	16114	15810	15599	15599
query23_1	15700	15928	15673	15673
query24	7421	1638	1239	1239
query24_1	1241	1223	1227	1223
query25	543	459	431	431
query26	1242	274	151	151
query27	2775	487	297	297
query28	4408	1844	1838	1838
query29	845	587	522	522
query30	300	230	192	192
query31	1034	952	893	893
query32	80	70	69	69
query33	505	358	304	304
query34	888	868	537	537
query35	663	688	625	625
query36	1071	1099	945	945
query37	139	93	83	83
query38	2937	2926	2904	2904
query39	860	840	814	814
query39_1	793	803	795	795
query40	245	162	145	145
query41	69	66	67	66
query42	264	268	260	260
query43	248	260	229	229
query44	
query45	200	203	188	188
query46	896	993	639	639
query47	2091	2768	2047	2047
query48	323	329	240	240
query49	652	495	408	408
query50	704	284	218	218
query51	4039	4051	4011	4011
query52	267	276	261	261
query53	299	343	296	296
query54	326	300	298	298
query55	95	89	89	89
query56	346	355	342	342
query57	1942	1703	1814	1703
query58	303	277	286	277
query59	2781	2982	2749	2749
query60	362	369	344	344
query61	185	181	182	181
query62	653	593	550	550
query63	315	284	287	284
query64	5054	1389	1109	1109
query65	
query66	1473	468	377	377
query67	24307	24302	24301	24301
query68	
query69	405	321	295	295
query70	1000	974	970	970
query71	349	328	306	306
query72	2840	2648	2438	2438
query73	558	550	325	325
query74	9631	9588	9424	9424
query75	2871	2743	2458	2458
query76	2091	1032	714	714
query77	366	407	307	307
query78	10916	11171	10451	10451
query79	1544	788	581	581
query80	1329	628	542	542
query81	559	260	235	235
query82	964	152	121	121
query83	344	270	244	244
query84	300	119	94	94
query85	899	507	452	452
query86	430	338	300	300
query87	3136	3123	3012	3012
query88	3603	2679	2683	2679
query89	445	376	348	348
query90	2019	184	186	184
query91	176	164	140	140
query92	81	81	71	71
query93	1001	868	503	503
query94	617	332	291	291
query95	596	407	324	324
query96	647	523	231	231
query97	2491	2479	2382	2382
query98	245	225	229	225
query99	999	940	912	912
Total cold run time: 249598 ms
Total hot run time: 169274 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (19780/37532)
Line Coverage 36.25% (184808/509865)
Region Coverage 32.49% (143037/440261)
Branch Coverage 33.67% (62562/185793)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.65% (26322/36735)
Line Coverage 54.50% (276960/508151)
Region Coverage 51.74% (229899/444307)
Branch Coverage 53.16% (99021/186275)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants