[fix](sql-functions) provide setup data for numeric-function examples querying an undefined table#3878
Merged
morningman merged 1 commit intoJun 3, 2026
Conversation
… querying an undefined table
ROUND_BANKERS and UNIFORM each show a `SELECT ... FROM <table>` example with an
expected result, but never define the table on the page, so the examples cannot be
run or reproduced ("table does not exist").
Add the missing CREATE TABLE + INSERT for each table (`test_enhanced_round` for
ROUND_BANKERS; `it` and `fn_test` for UNIFORM), carried in a standard HTML comment
(`<!-- setup-sql ... -->`) before the example. As an HTML comment it does not change
the rendered page, and no documented expected output is modified.
Table contents were reverse-derived from the printed output and verified end-to-end
on the matching release cluster for each doc tree: ROUND_BANKERS on 4.1.1 / 3.1.4 /
2.1.11 / master; UNIFORM (dev + version-4.x only) on 4.1.1 / master. The deterministic
examples now resolve and match the documented output (UNIFORM's random()-seeded
examples remain inherently non-deterministic, as the doc itself notes).
ROUND_BANKERS updated in EN + ZH across dev/current, version-4.x, version-3.x and
version-2.1; UNIFORM in EN + ZH across dev/current and version-4.x.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ROUND_BANKERSandUNIFORMpages each show aSELECT ... FROM <table>example with an expected result, but never define the table on the page. As written these examples cannot be run or reproduced — a reader who copies them getsTable [...] does not exist.This PR adds the missing
CREATE TABLE+INSERTfor each table, carried in a standard HTML comment (<!-- setup-sql ... -->) just before the example. Because it is an HTML comment, the rendered page is unchanged and no documented expected output is modified.Pages and tables
ROUND_BANKERStest_enhanced_roundUNIFORMit,fn_testROUND_BANKERSis updated in EN + ZH across dev/current,version-4.x,version-3.xandversion-2.1;UNIFORMexists only in dev/currentandversion-4.x(12 files total). Verified end-to-end: ROUND_BANKERS on 4.1.1 / 3.1.4 / 2.1.11 / master, UNIFORM on 4.1.1 / master. The deterministic examples failed with "table does not exist" before this change and match the documented output after it. (UNIFORMsrandom()-seeded examples are inherently non-deterministic, as the page itself notes — those keep showing sample output.) Noja-sourcechanges.🤖 Generated with Claude Code