[fix](sql-functions) provide setup data for date-time-function examples querying an undefined table#3875
Merged
morningman merged 1 commit intoJun 3, 2026
Conversation
…es querying an undefined table
PERIOD_ADD, PERIOD_DIFF and TIME_FORMAT each show a `SELECT ... FROM <table>`
example with an expected result, but never define the table on the page, so the
examples cannot be run or reproduced ("table does not exist").
Add the missing CREATE TABLE + INSERT for each table, carried in a standard HTML
comment (`<!-- setup-sql ... -->`) before the example. As an HTML comment it does
not change the rendered page, and no documented expected output is modified.
Table contents were reverse-derived from the output already printed on each page
(test_period_add, test_period_diff, test_time_format + test_format) and verified
end-to-end: version-4.x on a 4.1.1 cluster and dev/current on a master build. On
both trees the examples failed with "table does not exist" before and now resolve
and match the documented output, including the large TIME_FORMAT specifier table.
Pages exist only in dev/current and version-4.x; updated in EN + ZH (12 files).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PERIOD_ADD,PERIOD_DIFFandTIME_FORMATpages each show aSELECT ... FROM <table>example with an expected result, but never define the table on the page. As written these examples cannot be run or reproduced — a reader who copies them getsTable [...] does not exist.This PR adds the missing
CREATE TABLE+INSERTfor each table, carried in a standard HTML comment (<!-- setup-sql ... -->) just before the example. Because it is an HTML comment, the rendered page is unchanged and no documented expected output is modified.Table contents were reverse-derived from the output already printed on each page and verified end-to-end on the matching cluster for each doc tree.
Pages and tables
PERIOD_ADDtest_period_addPERIOD_DIFFtest_period_diffTIME_FORMATtest_time_format,test_formatThese pages exist only in the dev/
currentandversion-4.xtrees; updated in EN + ZH (12 files). Verified on a 4.1.1 cluster (4.x) and a master build (dev): the affected examples failed with "table does not exist" before this change and pass (output matches the doc, including the full TIME_FORMAT specifier table) after it. Noja-sourcechanges.🤖 Generated with Claude Code