fix(azuredevops): handle 204 No Content in collectApiTimelineRecords timeline response#8958
Open
bujjibabukatta wants to merge 1 commit into
Open
fix(azuredevops): handle 204 No Content in collectApiTimelineRecords timeline response#8958bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @klesh could you please review and approve pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
collectApiTimelineRecordssubtask failing when the Azure DevOpsTimeline API returns
204 No Contentfor deleted or empty builds.Root Cause
ignoreInvalidTimelineResponse()only guarded against404 Not Found.When a
204 No Contentresponse was received, execution fell through toio.ReadAll(res.Body)on an empty body. While the downstream empty-bodycheck would eventually skip the record, reading the body of a
204responsebefore checking the status code is unsafe — some HTTP clients/proxies set
Body = nilon204, which causes a nil-pointer panic.Fix
Added an explicit
http.StatusNoContentguard alongside the existinghttp.StatusNotFoundcheck, before the body is ever read.Changes
tasks/shared.go— extend the status guard inignoreInvalidTimelineResponseto include
204 No Contenttasks/shared_test.go— addTestIgnoreInvalidTimelineResponse_204tocover the new guard
Testing
All existing tests continue to pass. New test
TestIgnoreInvalidTimelineResponse_204verifies that a
204response returnsapi.ErrIgnoreAndContinuewithoutreading the body.
Related
Closes #8944