test: Add slt for swapped cross join with conflicting metadata#23857
Open
mkleen wants to merge 1 commit into
Open
test: Add slt for swapped cross join with conflicting metadata#23857mkleen wants to merge 1 commit into
mkleen wants to merge 1 commit into
Conversation
Contributor
Author
|
Test fails without #23605. However, this only proves that the cross-join is working now in this case. The same issue could be at a lot of other code parts where two schemas get merged together. |
mkleen
marked this pull request as ready for review
July 24, 2026 10:04
mkleen
force-pushed
the
slt-cross-join-meta
branch
from
July 24, 2026 10:46
8db6242 to
ad64982
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23857 +/- ##
==========================================
- Coverage 80.71% 80.63% -0.09%
==========================================
Files 1090 1091 +1
Lines 370370 370738 +368
Branches 370370 370738 +368
==========================================
- Hits 298948 298935 -13
- Misses 53601 53961 +360
- Partials 17821 17842 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mkleen
force-pushed
the
slt-cross-join-meta
branch
from
July 25, 2026 05:22
ad64982 to
cbe2d91
Compare
Contributor
|
Thanks for the reproducer! I tend to think we might want to let this test case fail, here are more details in the original issue #23461, we could continue the discussion there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This adds a slt for #23605 to make sure it works end-to-end.
What changes are included in this PR?
test_context.rsAre these changes tested?
Yes
Are there any user-facing changes?
No