chore: update sqllogictest priority list with latest timing summary (8s --> 6s)#22549
Merged
Merged
Conversation
Refreshes the `TEST_PRIORITY_ENTRIES` list (and its example output) so the longest-running test files run first, based on the latest `--timing-summary` output. `nested_loop_join_spill.slt` is now the longest-running file and is promoted to the front of the list; several additional long-running files (`array/array_has.slt`, `cte.slt`, `sort_pushdown.slt`, `push_down_filter_parquet.slt`, `projection_pushdown.slt`) are added. Follows up on the prioritization mechanism added in apache#20656. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ab596b9 to
7434d88
Compare
Contributor
Author
|
Thank you for the review @2010YOUY01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Make running sqllogictests faster by improving scheduling / parallelism
The sqllogictest runner runs test files in parallel but each file
sequentially, so it prioritizes known long-running files to run first to
minimize total wall-clock time. This list was last set in #20656.
The relative timings have since shifted. Running with the
--timing-summaryflag now reports a different ordering of the longestfiles, with
nested_loop_join_spill.slthaving become the longest by afair margin:
$ cargo test --profile=ci --test sqllogictests -- --timing-summary Per-file elapsed summary (deterministic): 1. 5.437s nested_loop_join_spill.slt 2. 3.471s push_down_filter_regression.slt 3. 3.458s aggregate.slt 4. 3.065s joins.slt 5. 2.852s aggregate_skip_partial.slt 6. 2.832s imdb.slt 7. 2.453s window.slt 8. 1.831s group_by.slt 9. 1.282s clickbench.slt 10. 1.055s datetime/timestamps.slt 11. 0.994s array/array_has.slt 12. 0.840s cte.slt 13. 0.748s sort_pushdown.slt 14. 0.714s push_down_filter_parquet.slt 15. 0.668s projection_pushdown.sltWhat changes are included in this PR?
TEST_PRIORITY_ENTRIESto match the latest--timing-summaryorderingAre these changes tested?
There are some existing unit tests and I verified timings manually
cargo test --profile=ci --test sqllogictestsMain
This Branch
Are there any user-facing changes?
No.