Infer placeholder type from ANY/ALL subquery, unit tests#22545
Open
HairstonE wants to merge 1 commit into
Open
Infer placeholder type from ANY/ALL subquery, unit tests#22545HairstonE wants to merge 1 commit into
HairstonE wants to merge 1 commit into
Conversation
Contributor
|
I do not see any slt tests as part of this pr? I had codex write some and they seem to fail on the branch with "Schema error: Schema contains duplicate unqualified field name mark" in optimize_projections. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22475.
Rationale for this change
$1 = ANY (SELECT ...)and$1 <> ALL (SELECT ...)left the placeholder untyped becauseinfer_placeholder_typeshad no arm forSetComparison.What changes are included in this PR?
Adds the
SetComparisonarm toinfer_placeholder_types, reading the type from the subquery's projected column. Covers all quantifiers (ANY,ALL) and comparison operators.How are these changes tested?
Unit tests for
ANYandALLplaceholder inference, plus end-to-end sqllogictests withPREPARE/EXECUTE.Are there any user-facing changes?
No.