fix(datasource): keep stats absent when collect_stats is false#21149
Open
kumarUjjawal wants to merge 1 commit intoapache:mainfrom
Open
fix(datasource): keep stats absent when collect_stats is false#21149kumarUjjawal wants to merge 1 commit intoapache:mainfrom
kumarUjjawal wants to merge 1 commit intoapache:mainfrom
Conversation
kumarUjjawal
force-pushed
the
fix/collect_stat
branch
from
d612950 to
23fa3f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
num_rowsandtotal_byte_sizeare not defined (stat should be None instead of Some(0)) #2976Rationale for this change
get_statistics_with_limitwas copying first-file row/byte stats even whencollect_stats=false. This could returnExact(0)instead ofAbsent(unknown stats).What changes are included in this PR?
Summary stats are only initialized and merged when
collect_stats=true. Also fixes first-file columnbyte_sizeinitialization in thecollect_stats=truepath, and adds regression tests for both paths and limit behavior.Are these changes tested?
Yes
Are there any user-facing changes?