feat: add support for parquet content defined chunking options#21110
Open
kszucs wants to merge 7 commits intoapache:mainfrom
Open
feat: add support for parquet content defined chunking options#21110kszucs wants to merge 7 commits intoapache:mainfrom
kszucs wants to merge 7 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
kszucs
force-pushed
the
cdc
branch
4 times, most recently
from
47936bb to
9d757a2
Compare
Contributor
This is done in So once that PR is merged this one should be good to go |
github-actions
bot
added
the
documentation
… clean up proto handling - Change `CdcOptions::norm_level` from `i64` to `i32` to match parquet's type, replacing `config_field!(i64)` with `config_field!(i32)` and removing all now-unnecessary `as i32`/`as i64` casts - Add validation in `into_writer_properties_builder` for invalid CDC config: `min_chunk_size == 0` and `max_chunk_size <= min_chunk_size`, returning a proper `DataFusionError::Configuration` instead of panicking in the parquet layer - Add explanatory comments on why proto zero-value handling is asymmetric between chunk sizes (0 is invalid) and `norm_level` (0 is valid default) - Remove extra blank line in `ParquetOptions` config block - Remove unused `parquet` feature from `datafusion-proto-common/Cargo.toml` - Add three validation tests for the new error paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Expose the new Content-Defined Chunking feature from parquet-rs apache/arrow-rs#9450
What changes are included in this PR?
New parquet writer options for enabling CDC.
Are these changes tested?
In-progress.
Are there any user-facing changes?
New config options.
Depends on the 58.1 arrow-rs release.