chore: Deprecate usage of paste crate#20946
Open
coderfender wants to merge 3 commits intoapache:mainfrom
Open
Conversation
github-actions
bot
added
sql
Author
|
TODO : Deprecate paste crate usage in |
coderfender
force-pushed
the
deprecate_paste_module
branch
from
d3b8705 to
3fd56d0
Compare
coderfender
changed the title
Author
|
@martin-g , ready for your review |
Author
|
@comphead , I took the more laborious approach to remove paste crate and replace the macro defs with elaborated arguments than trying to find a new crate. Almost all other past crate usage is in tests / non critical path of code with one major usage in UDWF and Error macros |
coderfender
changed the title
coderfender
force-pushed
the
deprecate_paste_module
branch
from
3fd56d0 to
1e54eeb
Compare
Author
|
Fixed a typo |
martin-g
reviewed
Mar 15, 2026
| /// Macro wraps `$ERR` to add backtrace feature | ||
| #[macro_export] | ||
| macro_rules! $NAME_DF_ERR { | ||
| ($d($d args:expr),* $d(; diagnostic=$d DIAG:expr)?) => {{ |
Member
There was a problem hiding this comment.
Suggested change
| ($d($d args:expr),* $d(; diagnostic=$d DIAG:expr)?) => {{ | |
| ($d($d args:expr),* $d(; diagnostic = $d DIAG:expr)?) => {{ |
for consistency with the other macros
Author
|
Thank you for the review @martin-g . Fixed the typo with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
pastecrate from the project #20853Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?