Add datafusion/arrow_canonical_extension_types feature#20908
Open
Tpt wants to merge 1 commit intoapache:mainfrom
Open
Add datafusion/arrow_canonical_extension_types feature#20908Tpt wants to merge 1 commit intoapache:mainfrom
Tpt wants to merge 1 commit intoapache:mainfrom
Conversation
alamb
reviewed
Mar 13, 2026
| object_store = { workspace = true } | ||
| parking_lot = { workspace = true } | ||
| parquet = { workspace = true, optional = true, default-features = true } | ||
| parquet = { workspace = true, optional = true, default-features = true, features = ["arrow_canonical_extension_types"] } |
Contributor
There was a problem hiding this comment.
should we make this a feature of DataFusion?
I also think it might be a good idea to show how to use these canonical types in DataFusion (maybe with an example)?
Contributor
Author
There was a problem hiding this comment.
Thank you! I have updated the MR to make it a feature.
I have only added a test. For an example I guess a good approach might be to import a part of https://github.com/timsaucer/datafusion_extension_type_examples
@timsaucer what do you think about it?
Wraps `parquet/arrow_canonical_extension_types` and `arrow-schema/canonical_extension_types` This feature is enabled by default (`arrow-schema/canonical_extension_types` was enabled by default) It might be a good flag to hide behind support for canonical extension types in various DataFusion operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
parquet/arrow_canonical_extension_typesandarrow-schema/canonical_extension_typesThis feature is enabled by default (
arrow-schema/canonical_extension_typeswas enabled by default)It might be a good flag to hide behind support for canonical extension types in various DataFusion operators