Consolidate cte_quoted_reference.slt into cte.slt #19862
+60
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merged CTE reference resolution tests into main cte.slt file - Added CREATE TABLE statement for orders table used in tests - Fixed 3 case-sensitivity issues: changed 'WHERE N < 10' to 'WHERE n < 10' Fixes apache#19786
Jefffrey
approved these changes
Jan 18, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Fixed 3 pre-existing case-sensitivity bugs by changing WHERE N < 10 to WHERE n < 10 in recursive CTE tests
Not exactly sure how these are bugs 🤔
| ---- | ||
| 1 | ||
| 2 | ||
|
|
Contributor
There was a problem hiding this comment.
Would be good to ensure we cleanup the orders table to ensure this section of tests are isolated
Contributor
|
Thank you @AnjaliChoudhary99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19786
Which issue does this PR close?
Rationale for this change
This PR consolidates the small test file
cte_quoted_reference.sltinto the maincte.sltfile as requested in issue #19786. The separate file was small enough that it didn't need to be maintained independently, and consolidating it improves code organization and maintainability.What changes are included in this PR?
cte_quoted_reference.sltintocte.sltCREATE TABLE orders AS VALUES (1), (2);statement to support the merged testsWHERE N < 10toWHERE n < 10in recursive CTE testscte_quoted_reference.sltas it's now consolidated into the main fileAre these changes tested?
Yes, all changes are tested:
cte_quoted_reference.sltare now part of thecte.slttest suitecargo test --test sqllogictests -- cten)Are there any user-facing changes?
No, there are no user-facing changes. This is purely a test file reorganization that improves code maintainability without affecting DataFusion's functionality or API.