Skip to content

[BENCH] Benchmark upgrade coalesce improvements#19851

Draft
Dandandan wants to merge 20 commits intoapache:mainfrom
Dandandan:test_upgrade_coalesce
Draft

[BENCH] Benchmark upgrade coalesce improvements#19851
Dandandan wants to merge 20 commits intoapache:mainfrom
Dandandan:test_upgrade_coalesce

Conversation

@Dandandan
Copy link
Contributor

No description provided.

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) common Related to common crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Jan 16, 2026
@Dandandan
Copy link
Contributor Author

run benchmarks

@Dandandan
Copy link
Contributor Author

run benchmark tpch tpcds

@Dandandan
Copy link
Contributor Author

show benchmark queue

@alamb-ghbot
Copy link

🤖 Hi @Dandandan, you asked to view the benchmark queue (#19851 (comment)).

Job User Benchmarks Comment
19792_3759692216.sh alamb sql_planner https://github.com/apache/datafusion/pull/19792#issuecomment-3759692216
19728_3759722184.sh Dandandan default https://github.com/apache/datafusion/pull/19728#issuecomment-3759722184
19728_3759762956.sh Dandandan tpch tpcds https://github.com/apache/datafusion/pull/19728#issuecomment-3759762956
19851_3759779688.sh Dandandan default https://github.com/apache/datafusion/pull/19851#issuecomment-3759779688
19851_3759780140.sh Dandandan tpch tpcds https://github.com/apache/datafusion/pull/19851#issuecomment-3759780140

@Dandandan Dandandan changed the title [BENCH] Benchmark upgrade coalesce [BENCH] Benchmark upgrade coalesce improvements Jan 16, 2026
@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (d9d8881) to b9a3b9f diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │  2431.99 ms │            2275.40 ms │ +1.07x faster │
│ QQuery 1 │   975.85 ms │             951.21 ms │     no change │
│ QQuery 2 │  1867.31 ms │            1841.13 ms │     no change │
│ QQuery 3 │  1187.68 ms │            1152.85 ms │     no change │
│ QQuery 4 │  2256.50 ms │            2242.88 ms │     no change │
│ QQuery 5 │ 28362.24 ms │           28146.06 ms │     no change │
│ QQuery 6 │  4032.96 ms │            3830.83 ms │ +1.05x faster │
│ QQuery 7 │  3537.18 ms │            3444.10 ms │     no change │
└──────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 44651.70ms │
│ Total Time (test_upgrade_coalesce)   │ 43884.46ms │
│ Average Time (HEAD)                  │  5581.46ms │
│ Average Time (test_upgrade_coalesce) │  5485.56ms │
│ Queries Faster                       │          2 │
│ Queries Slower                       │          0 │
│ Queries with No Change               │          6 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     1.89 ms │               1.89 ms │     no change │
│ QQuery 1  │    50.51 ms │              48.57 ms │     no change │
│ QQuery 2  │   134.44 ms │             164.11 ms │  1.22x slower │
│ QQuery 3  │   152.75 ms │             161.69 ms │  1.06x slower │
│ QQuery 4  │  1082.26 ms │            1056.74 ms │     no change │
│ QQuery 5  │  1387.47 ms │            1351.69 ms │     no change │
│ QQuery 6  │     1.81 ms │               1.86 ms │     no change │
│ QQuery 7  │    55.24 ms │              52.57 ms │     no change │
│ QQuery 8  │  1421.05 ms │            1422.19 ms │     no change │
│ QQuery 9  │  1841.00 ms │            1857.40 ms │     no change │
│ QQuery 10 │   339.39 ms │             344.16 ms │     no change │
│ QQuery 11 │   391.55 ms │             387.62 ms │     no change │
│ QQuery 12 │  1282.52 ms │            1268.08 ms │     no change │
│ QQuery 13 │  1928.50 ms │            1937.82 ms │     no change │
│ QQuery 14 │  1244.46 ms │            1230.57 ms │     no change │
│ QQuery 15 │  1229.10 ms │            1214.49 ms │     no change │
│ QQuery 16 │  2559.47 ms │            2513.09 ms │     no change │
│ QQuery 17 │  2522.77 ms │            2447.39 ms │     no change │
│ QQuery 18 │  5873.52 ms │            5034.87 ms │ +1.17x faster │
│ QQuery 19 │   119.44 ms │             116.42 ms │     no change │
│ QQuery 20 │  1928.90 ms │            1910.60 ms │     no change │
│ QQuery 21 │  2245.08 ms │            2129.71 ms │ +1.05x faster │
│ QQuery 22 │  8479.61 ms │            3654.67 ms │ +2.32x faster │
│ QQuery 23 │ 25065.87 ms │           11886.61 ms │ +2.11x faster │
│ QQuery 24 │   222.45 ms │             204.12 ms │ +1.09x faster │
│ QQuery 25 │   479.00 ms │             443.05 ms │ +1.08x faster │
│ QQuery 26 │   222.46 ms │             217.65 ms │     no change │
│ QQuery 27 │  2835.45 ms │            2663.69 ms │ +1.06x faster │
│ QQuery 28 │ 24106.47 ms │           23088.03 ms │     no change │
│ QQuery 29 │   970.74 ms │             977.81 ms │     no change │
│ QQuery 30 │  1321.80 ms │            1286.47 ms │     no change │
│ QQuery 31 │  1407.59 ms │            1300.95 ms │ +1.08x faster │
│ QQuery 32 │  4966.68 ms │            4864.11 ms │     no change │
│ QQuery 33 │  5715.91 ms │            5223.09 ms │ +1.09x faster │
│ QQuery 34 │  5902.36 ms │            5701.46 ms │     no change │
│ QQuery 35 │  1909.25 ms │            1899.40 ms │     no change │
│ QQuery 36 │    67.56 ms │              67.93 ms │     no change │
│ QQuery 37 │    45.08 ms │              46.38 ms │     no change │
│ QQuery 38 │    66.21 ms │              64.19 ms │     no change │
│ QQuery 39 │   102.57 ms │             102.02 ms │     no change │
│ QQuery 40 │    27.64 ms │              26.83 ms │     no change │
│ QQuery 41 │    23.12 ms │              23.21 ms │     no change │
│ QQuery 42 │    19.40 ms │              20.44 ms │  1.05x slower │
└───────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃             ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 111750.37ms │
│ Total Time (test_upgrade_coalesce)   │  90415.64ms │
│ Average Time (HEAD)                  │   2598.85ms │
│ Average Time (test_upgrade_coalesce) │   2102.69ms │
│ Queries Faster                       │           9 │
│ Queries Slower                       │           3 │
│ Queries with No Change               │          31 │
│ Queries with Failure                 │           0 │
└──────────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 118.73 ms │             122.23 ms │     no change │
│ QQuery 2  │  39.84 ms │              36.96 ms │ +1.08x faster │
│ QQuery 3  │  41.99 ms │              42.04 ms │     no change │
│ QQuery 4  │  31.66 ms │              32.06 ms │     no change │
│ QQuery 5  │  92.22 ms │              84.30 ms │ +1.09x faster │
│ QQuery 6  │  20.88 ms │              20.74 ms │     no change │
│ QQuery 7  │ 224.56 ms │             224.42 ms │     no change │
│ QQuery 8  │  41.53 ms │              42.23 ms │     no change │
│ QQuery 9  │ 105.67 ms │              99.92 ms │ +1.06x faster │
│ QQuery 10 │  68.96 ms │              63.78 ms │ +1.08x faster │
│ QQuery 11 │  24.76 ms │              24.03 ms │     no change │
│ QQuery 12 │  54.43 ms │              51.12 ms │ +1.06x faster │
│ QQuery 13 │  49.83 ms │              48.04 ms │     no change │
│ QQuery 14 │  15.13 ms │              14.58 ms │     no change │
│ QQuery 15 │  30.47 ms │              29.78 ms │     no change │
│ QQuery 16 │  28.93 ms │              27.26 ms │ +1.06x faster │
│ QQuery 17 │ 151.73 ms │             153.31 ms │     no change │
│ QQuery 18 │ 287.70 ms │             272.92 ms │ +1.05x faster │
│ QQuery 19 │  38.39 ms │              39.07 ms │     no change │
│ QQuery 20 │  58.63 ms │              56.05 ms │     no change │
│ QQuery 21 │ 316.38 ms │             301.30 ms │     no change │
│ QQuery 22 │  22.32 ms │              22.13 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1864.75ms │
│ Total Time (test_upgrade_coalesce)   │ 1808.27ms │
│ Average Time (HEAD)                  │   84.76ms │
│ Average Time (test_upgrade_coalesce) │   82.19ms │
│ Queries Faster                       │         7 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        15 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (d9d8881) to b9a3b9f diff using: tpch
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │  2407.32 ms │            2282.54 ms │ +1.05x faster │
│ QQuery 1 │   944.09 ms │             916.64 ms │     no change │
│ QQuery 2 │  1896.63 ms │            1864.36 ms │     no change │
│ QQuery 3 │  1126.22 ms │            1101.73 ms │     no change │
│ QQuery 4 │  2227.35 ms │            2161.06 ms │     no change │
│ QQuery 5 │ 28450.22 ms │           28451.19 ms │     no change │
│ QQuery 6 │  4012.28 ms │            3774.83 ms │ +1.06x faster │
│ QQuery 7 │  3010.52 ms │            2912.10 ms │     no change │
└──────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 44074.62ms │
│ Total Time (test_upgrade_coalesce)   │ 43464.45ms │
│ Average Time (HEAD)                  │  5509.33ms │
│ Average Time (test_upgrade_coalesce) │  5433.06ms │
│ Queries Faster                       │          2 │
│ Queries Slower                       │          0 │
│ Queries with No Change               │          6 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     1.88 ms │               2.01 ms │  1.07x slower │
│ QQuery 1  │    50.94 ms │              48.74 ms │     no change │
│ QQuery 2  │   136.00 ms │             151.64 ms │  1.12x slower │
│ QQuery 3  │   157.29 ms │             158.54 ms │     no change │
│ QQuery 4  │  1066.67 ms │            1098.33 ms │     no change │
│ QQuery 5  │  1353.90 ms │            1350.27 ms │     no change │
│ QQuery 6  │     1.82 ms │               1.87 ms │     no change │
│ QQuery 7  │    56.70 ms │              52.06 ms │ +1.09x faster │
│ QQuery 8  │  1413.57 ms │            1447.41 ms │     no change │
│ QQuery 9  │  1752.20 ms │            1780.64 ms │     no change │
│ QQuery 10 │   346.99 ms │             334.66 ms │     no change │
│ QQuery 11 │   396.36 ms │             381.13 ms │     no change │
│ QQuery 12 │  1273.94 ms │            1259.58 ms │     no change │
│ QQuery 13 │  1952.95 ms │            1893.18 ms │     no change │
│ QQuery 14 │  1246.98 ms │            1210.15 ms │     no change │
│ QQuery 15 │  1223.52 ms │            1247.99 ms │     no change │
│ QQuery 16 │  2548.28 ms │            2514.27 ms │     no change │
│ QQuery 17 │  2530.77 ms │            2482.01 ms │     no change │
│ QQuery 18 │  5953.61 ms │            4809.97 ms │ +1.24x faster │
│ QQuery 19 │   123.22 ms │             118.72 ms │     no change │
│ QQuery 20 │  1947.08 ms │            1863.32 ms │     no change │
│ QQuery 21 │  2203.41 ms │            2153.89 ms │     no change │
│ QQuery 22 │  3817.55 ms │            3670.74 ms │     no change │
│ QQuery 23 │ 23706.76 ms │           11990.05 ms │ +1.98x faster │
│ QQuery 24 │   212.75 ms │             206.85 ms │     no change │
│ QQuery 25 │   475.58 ms │             459.48 ms │     no change │
│ QQuery 26 │   218.47 ms │             215.36 ms │     no change │
│ QQuery 27 │  2780.04 ms │            2608.69 ms │ +1.07x faster │
│ QQuery 28 │ 24017.81 ms │           24298.58 ms │     no change │
│ QQuery 29 │   945.31 ms │             962.29 ms │     no change │
│ QQuery 30 │  1309.49 ms │            1237.07 ms │ +1.06x faster │
│ QQuery 31 │  1365.48 ms │            1279.34 ms │ +1.07x faster │
│ QQuery 32 │  4752.74 ms │            4524.05 ms │     no change │
│ QQuery 33 │  5763.12 ms │            5452.23 ms │ +1.06x faster │
│ QQuery 34 │  5948.49 ms │            5716.11 ms │     no change │
│ QQuery 35 │  1923.14 ms │            1923.83 ms │     no change │
│ QQuery 36 │    67.52 ms │              68.67 ms │     no change │
│ QQuery 37 │    47.57 ms │              45.08 ms │ +1.06x faster │
│ QQuery 38 │    70.23 ms │              67.42 ms │     no change │
│ QQuery 39 │   106.00 ms │             104.75 ms │     no change │
│ QQuery 40 │    27.62 ms │              27.68 ms │     no change │
│ QQuery 41 │    23.83 ms │              23.99 ms │     no change │
│ QQuery 42 │    19.31 ms │              20.50 ms │  1.06x slower │
└───────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃             ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 105336.88ms │
│ Total Time (test_upgrade_coalesce)   │  91263.13ms │
│ Average Time (HEAD)                  │   2449.69ms │
│ Average Time (test_upgrade_coalesce) │   2122.40ms │
│ Queries Faster                       │           8 │
│ Queries Slower                       │           3 │
│ Queries with No Change               │          32 │
│ Queries with Failure                 │           0 │
└──────────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 132.82 ms │             104.15 ms │ +1.28x faster │
│ QQuery 2  │  36.46 ms │              30.65 ms │ +1.19x faster │
│ QQuery 3  │  42.65 ms │              33.79 ms │ +1.26x faster │
│ QQuery 4  │  31.31 ms │              30.69 ms │     no change │
│ QQuery 5  │  91.15 ms │              81.04 ms │ +1.12x faster │
│ QQuery 6  │  20.72 ms │              20.55 ms │     no change │
│ QQuery 7  │ 156.74 ms │             146.53 ms │ +1.07x faster │
│ QQuery 8  │  39.09 ms │              38.94 ms │     no change │
│ QQuery 9  │ 103.91 ms │             100.26 ms │     no change │
│ QQuery 10 │  68.80 ms │              61.35 ms │ +1.12x faster │
│ QQuery 11 │  18.89 ms │              18.41 ms │     no change │
│ QQuery 12 │  53.93 ms │              50.76 ms │ +1.06x faster │
│ QQuery 13 │  48.26 ms │              49.53 ms │     no change │
│ QQuery 14 │  15.31 ms │              14.35 ms │ +1.07x faster │
│ QQuery 15 │  31.57 ms │              29.25 ms │ +1.08x faster │
│ QQuery 16 │  29.79 ms │              27.30 ms │ +1.09x faster │
│ QQuery 17 │ 146.13 ms │             144.78 ms │     no change │
│ QQuery 18 │ 287.40 ms │             274.48 ms │     no change │
│ QQuery 19 │  39.58 ms │              38.89 ms │     no change │
│ QQuery 20 │  56.26 ms │              56.66 ms │     no change │
│ QQuery 21 │ 191.22 ms │             188.65 ms │     no change │
│ QQuery 22 │  22.74 ms │              21.98 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1664.73ms │
│ Total Time (test_upgrade_coalesce)   │ 1563.03ms │
│ Average Time (HEAD)                  │   75.67ms │
│ Average Time (test_upgrade_coalesce) │   71.05ms │
│ Queries Faster                       │        10 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        12 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (b31e3f5) to 3d90d4b diff using: tpch
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 184.07 ms │             179.48 ms │     no change │
│ QQuery 2  │  89.13 ms │              84.52 ms │ +1.05x faster │
│ QQuery 3  │ 124.66 ms │             123.16 ms │     no change │
│ QQuery 4  │  77.67 ms │              79.28 ms │     no change │
│ QQuery 5  │ 177.59 ms │             169.73 ms │     no change │
│ QQuery 6  │  65.92 ms │              64.86 ms │     no change │
│ QQuery 7  │ 215.17 ms │             204.24 ms │ +1.05x faster │
│ QQuery 8  │ 175.43 ms │             165.78 ms │ +1.06x faster │
│ QQuery 9  │ 237.78 ms │             230.10 ms │     no change │
│ QQuery 10 │ 191.23 ms │             182.97 ms │     no change │
│ QQuery 11 │  63.67 ms │              59.29 ms │ +1.07x faster │
│ QQuery 12 │ 120.24 ms │             117.61 ms │     no change │
│ QQuery 13 │ 217.70 ms │             220.41 ms │     no change │
│ QQuery 14 │  94.60 ms │              86.19 ms │ +1.10x faster │
│ QQuery 15 │ 127.04 ms │             122.11 ms │     no change │
│ QQuery 16 │  61.47 ms │              60.02 ms │     no change │
│ QQuery 17 │ 264.52 ms │             284.56 ms │  1.08x slower │
│ QQuery 18 │ 314.12 ms │             304.52 ms │     no change │
│ QQuery 19 │ 137.14 ms │             134.31 ms │     no change │
│ QQuery 20 │ 128.69 ms │             131.60 ms │     no change │
│ QQuery 21 │ 259.21 ms │             250.07 ms │     no change │
│ QQuery 22 │  38.93 ms │              38.65 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 3365.95ms │
│ Total Time (test_upgrade_coalesce)   │ 3293.45ms │
│ Average Time (HEAD)                  │  153.00ms │
│ Average Time (test_upgrade_coalesce) │  149.70ms │
│ Queries Faster                       │         5 │
│ Queries Slower                       │         1 │
│ Queries with No Change               │        16 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (b31e3f5) to 3d90d4b diff using: tpcds
Results will be posted here when complete

@Dandandan
Copy link
Contributor Author

run benchmark tpch_mem

@Dandandan
Copy link
Contributor Author

Tpch_mem looks promising, even without byteview support yet

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │    70.91 ms │              69.77 ms │     no change │
│ QQuery 2  │   216.35 ms │             208.38 ms │     no change │
│ QQuery 3  │   160.18 ms │             158.50 ms │     no change │
│ QQuery 4  │  1881.57 ms │            1809.73 ms │     no change │
│ QQuery 5  │   289.62 ms │             285.21 ms │     no change │
│ QQuery 6  │  1443.87 ms │            1435.43 ms │     no change │
│ QQuery 7  │   501.94 ms │             483.86 ms │     no change │
│ QQuery 8  │   173.31 ms │             172.30 ms │     no change │
│ QQuery 9  │   295.69 ms │             300.60 ms │     no change │
│ QQuery 10 │   173.13 ms │             169.12 ms │     no change │
│ QQuery 11 │  1265.13 ms │            1226.86 ms │     no change │
│ QQuery 12 │    72.61 ms │              67.28 ms │ +1.08x faster │
│ QQuery 13 │   536.17 ms │             533.77 ms │     no change │
│ QQuery 14 │  1867.88 ms │            1838.79 ms │     no change │
│ QQuery 15 │    31.06 ms │              30.76 ms │     no change │
│ QQuery 16 │    68.03 ms │              64.62 ms │ +1.05x faster │
│ QQuery 17 │   368.13 ms │             360.25 ms │     no change │
│ QQuery 18 │   198.32 ms │             186.69 ms │ +1.06x faster │
│ QQuery 19 │   228.68 ms │             225.81 ms │     no change │
│ QQuery 20 │    25.53 ms │              25.25 ms │     no change │
│ QQuery 21 │    39.43 ms │              38.52 ms │     no change │
│ QQuery 22 │   708.10 ms │             742.50 ms │     no change │
│ QQuery 23 │  1765.29 ms │            1744.11 ms │     no change │
│ QQuery 24 │   683.02 ms │             667.07 ms │     no change │
│ QQuery 25 │   529.88 ms │             514.63 ms │     no change │
│ QQuery 26 │   131.30 ms │             126.24 ms │     no change │
│ QQuery 27 │   500.43 ms │             486.67 ms │     no change │
│ QQuery 28 │   294.77 ms │             298.25 ms │     no change │
│ QQuery 29 │   448.35 ms │             452.39 ms │     no change │
│ QQuery 30 │    76.08 ms │              71.02 ms │ +1.07x faster │
│ QQuery 31 │   313.03 ms │             313.75 ms │     no change │
│ QQuery 32 │    84.31 ms │              82.45 ms │     no change │
│ QQuery 33 │   204.40 ms │             207.30 ms │     no change │
│ QQuery 34 │   158.02 ms │             158.72 ms │     no change │
│ QQuery 35 │   177.46 ms │             165.50 ms │ +1.07x faster │
│ QQuery 36 │   283.61 ms │             277.79 ms │     no change │
│ QQuery 37 │   255.85 ms │             253.01 ms │     no change │
│ QQuery 38 │   150.74 ms │             149.15 ms │     no change │
│ QQuery 39 │   215.01 ms │             207.47 ms │     no change │
│ QQuery 40 │   176.51 ms │             170.39 ms │     no change │
│ QQuery 41 │    24.33 ms │              23.23 ms │     no change │
│ QQuery 42 │   141.76 ms │             141.63 ms │     no change │
│ QQuery 43 │   124.66 ms │             124.47 ms │     no change │
│ QQuery 44 │    28.76 ms │              28.77 ms │     no change │
│ QQuery 45 │    89.64 ms │              89.32 ms │     no change │
│ QQuery 46 │   315.71 ms │             310.67 ms │     no change │
│ QQuery 47 │   993.70 ms │             989.43 ms │     no change │
│ QQuery 48 │   401.84 ms │             398.23 ms │     no change │
│ QQuery 49 │   370.83 ms │             362.47 ms │     no change │
│ QQuery 50 │   336.35 ms │             349.57 ms │     no change │
│ QQuery 51 │   299.97 ms │             300.15 ms │     no change │
│ QQuery 52 │   143.51 ms │             143.32 ms │     no change │
│ QQuery 53 │   150.36 ms │             149.82 ms │     no change │
│ QQuery 54 │   213.35 ms │             217.41 ms │     no change │
│ QQuery 55 │   141.74 ms │             143.14 ms │     no change │
│ QQuery 56 │   206.27 ms │             207.59 ms │     no change │
│ QQuery 57 │   297.07 ms │             289.17 ms │     no change │
│ QQuery 58 │   488.56 ms │             472.99 ms │     no change │
│ QQuery 59 │   284.31 ms │             289.14 ms │     no change │
│ QQuery 60 │   208.73 ms │             209.95 ms │     no change │
│ QQuery 61 │   237.94 ms │             243.22 ms │     no change │
│ QQuery 62 │  1282.05 ms │            1398.12 ms │  1.09x slower │
│ QQuery 63 │   151.81 ms │             151.79 ms │     no change │
│ QQuery 64 │  1181.28 ms │            1122.98 ms │     no change │
│ QQuery 65 │   341.71 ms │             352.49 ms │     no change │
│ QQuery 66 │   404.44 ms │             397.68 ms │     no change │
│ QQuery 67 │   533.83 ms │             532.65 ms │     no change │
│ QQuery 68 │   365.24 ms │             366.79 ms │     no change │
│ QQuery 69 │   175.20 ms │             163.60 ms │ +1.07x faster │
│ QQuery 70 │   492.71 ms │             497.11 ms │     no change │
│ QQuery 71 │   183.14 ms │             182.75 ms │     no change │
│ QQuery 72 │  2106.67 ms │            2018.38 ms │     no change │
│ QQuery 73 │   156.13 ms │             153.22 ms │     no change │
│ QQuery 74 │   786.90 ms │             785.93 ms │     no change │
│ QQuery 75 │   398.06 ms │             399.77 ms │     no change │
│ QQuery 76 │   183.98 ms │             187.63 ms │     no change │
│ QQuery 77 │   286.46 ms │             287.43 ms │     no change │
│ QQuery 78 │   959.96 ms │             942.75 ms │     no change │
│ QQuery 79 │   319.68 ms │             316.45 ms │     no change │
│ QQuery 80 │   512.77 ms │             512.00 ms │     no change │
│ QQuery 81 │    52.75 ms │              51.57 ms │     no change │
│ QQuery 82 │   279.00 ms │             282.73 ms │     no change │
│ QQuery 83 │    81.98 ms │              80.22 ms │     no change │
│ QQuery 84 │    70.31 ms │              63.31 ms │ +1.11x faster │
│ QQuery 85 │   220.15 ms │             219.63 ms │     no change │
│ QQuery 86 │    58.37 ms │              56.52 ms │     no change │
│ QQuery 87 │   151.48 ms │             152.49 ms │     no change │
│ QQuery 88 │   266.84 ms │             267.24 ms │     no change │
│ QQuery 89 │   169.70 ms │             167.50 ms │     no change │
│ QQuery 90 │    48.96 ms │              46.56 ms │     no change │
│ QQuery 91 │   101.71 ms │              94.89 ms │ +1.07x faster │
│ QQuery 92 │    83.18 ms │              82.51 ms │     no change │
│ QQuery 93 │   274.26 ms │             277.05 ms │     no change │
│ QQuery 94 │    92.49 ms │              92.54 ms │     no change │
│ QQuery 95 │   250.66 ms │             254.71 ms │     no change │
│ QQuery 96 │   111.94 ms │             113.67 ms │     no change │
│ QQuery 97 │   192.57 ms │             188.30 ms │     no change │
│ QQuery 98 │   217.49 ms │             205.47 ms │ +1.06x faster │
│ QQuery 99 │ 14068.29 ms │           15937.87 ms │  1.13x slower │
└───────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 50177.27ms │
│ Total Time (test_upgrade_coalesce)   │ 51667.92ms │
│ Average Time (HEAD)                  │   506.84ms │
│ Average Time (test_upgrade_coalesce) │   521.90ms │
│ Queries Faster                       │          9 │
│ Queries Slower                       │          2 │
│ Queries with No Change               │         88 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (b31e3f5) to 3d90d4b diff using: tpch_mem
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 109.09 ms │             105.53 ms │     no change │
│ QQuery 2  │  33.21 ms │              31.46 ms │ +1.06x faster │
│ QQuery 3  │  45.34 ms │              41.78 ms │ +1.09x faster │
│ QQuery 4  │  32.71 ms │              32.33 ms │     no change │
│ QQuery 5  │  94.57 ms │              82.85 ms │ +1.14x faster │
│ QQuery 6  │  20.85 ms │              21.11 ms │     no change │
│ QQuery 7  │ 165.54 ms │             159.53 ms │     no change │
│ QQuery 8  │  41.89 ms │              40.61 ms │     no change │
│ QQuery 9  │ 108.60 ms │             102.72 ms │ +1.06x faster │
│ QQuery 10 │  71.06 ms │              65.42 ms │ +1.09x faster │
│ QQuery 11 │  19.42 ms │              19.08 ms │     no change │
│ QQuery 12 │  51.43 ms │              51.21 ms │     no change │
│ QQuery 13 │  49.03 ms │              48.96 ms │     no change │
│ QQuery 14 │  15.99 ms │              15.27 ms │     no change │
│ QQuery 15 │  31.21 ms │              30.55 ms │     no change │
│ QQuery 16 │  28.73 ms │              28.47 ms │     no change │
│ QQuery 17 │ 151.81 ms │             148.87 ms │     no change │
│ QQuery 18 │ 289.50 ms │             272.60 ms │ +1.06x faster │
│ QQuery 19 │  39.69 ms │              39.71 ms │     no change │
│ QQuery 20 │  57.59 ms │              57.94 ms │     no change │
│ QQuery 21 │ 188.87 ms │             200.98 ms │  1.06x slower │
│ QQuery 22 │  23.18 ms │              22.56 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1669.32ms │
│ Total Time (test_upgrade_coalesce)   │ 1619.53ms │
│ Average Time (HEAD)                  │   75.88ms │
│ Average Time (test_upgrade_coalesce) │   73.62ms │
│ Queries Faster                       │         6 │
│ Queries Slower                       │         1 │
│ Queries with No Change               │        15 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb
Copy link
Contributor

alamb commented Jan 18, 2026

Not too bad 😎

@Dandandan
Copy link
Contributor Author

run benchmark tpch_mem

@Dandandan
Copy link
Contributor Author

Hmmm... we're not even using the API with FilterExec yet 🙈
Retesting...

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jan 18, 2026
@Dandandan
Copy link
Contributor Author

run benchmarks

@Dandandan
Copy link
Contributor Author

run benchmark tpcds

@Dandandan
Copy link
Contributor Author

run benchmark tpch

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (6e1c407) to 3d90d4b diff using: tpch_mem
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 107.62 ms │             112.46 ms │     no change │
│ QQuery 2  │  34.57 ms │              31.34 ms │ +1.10x faster │
│ QQuery 3  │  40.07 ms │              35.82 ms │ +1.12x faster │
│ QQuery 4  │  31.81 ms │              29.69 ms │ +1.07x faster │
│ QQuery 5  │  92.12 ms │              80.16 ms │ +1.15x faster │
│ QQuery 6  │  20.72 ms │              20.42 ms │     no change │
│ QQuery 7  │ 160.33 ms │             146.95 ms │ +1.09x faster │
│ QQuery 8  │  39.70 ms │              38.19 ms │     no change │
│ QQuery 9  │ 100.89 ms │              94.79 ms │ +1.06x faster │
│ QQuery 10 │  70.79 ms │              61.78 ms │ +1.15x faster │
│ QQuery 11 │  18.16 ms │              18.37 ms │     no change │
│ QQuery 12 │  52.19 ms │              50.74 ms │     no change │
│ QQuery 13 │  47.88 ms │              47.88 ms │     no change │
│ QQuery 14 │  15.09 ms │              14.12 ms │ +1.07x faster │
│ QQuery 15 │  31.52 ms │              29.70 ms │ +1.06x faster │
│ QQuery 16 │  29.13 ms │              27.08 ms │ +1.08x faster │
│ QQuery 17 │ 146.49 ms │             140.68 ms │     no change │
│ QQuery 18 │ 285.99 ms │             258.87 ms │ +1.10x faster │
│ QQuery 19 │  39.27 ms │              37.97 ms │     no change │
│ QQuery 20 │  56.30 ms │              55.24 ms │     no change │
│ QQuery 21 │ 188.74 ms │             181.58 ms │     no change │
│ QQuery 22 │  22.36 ms │              21.74 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1631.73ms │
│ Total Time (test_upgrade_coalesce)   │ 1535.60ms │
│ Average Time (HEAD)                  │   74.17ms │
│ Average Time (test_upgrade_coalesce) │   69.80ms │
│ Queries Faster                       │        11 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        11 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (6e1c407) to 3d90d4b diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@Dandandan
Copy link
Contributor Author

Ahh this is starting to look better

@Dandandan
Copy link
Contributor Author

run benchmark tpch_mem

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query    ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0 │  2457.10 ms │            2291.21 ms │ +1.07x faster │
│ QQuery 1 │   923.00 ms │             935.36 ms │     no change │
│ QQuery 2 │  1882.44 ms │            1863.88 ms │     no change │
│ QQuery 3 │  1114.38 ms │            1104.64 ms │     no change │
│ QQuery 4 │  2198.01 ms │            2166.24 ms │     no change │
│ QQuery 5 │ 28458.18 ms │           27995.80 ms │     no change │
│ QQuery 6 │  4030.38 ms │            3851.23 ms │     no change │
│ QQuery 7 │  2746.04 ms │            2809.84 ms │     no change │
└──────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 43809.52ms │
│ Total Time (test_upgrade_coalesce)   │ 43018.21ms │
│ Average Time (HEAD)                  │  5476.19ms │
│ Average Time (test_upgrade_coalesce) │  5377.28ms │
│ Queries Faster                       │          1 │
│ Queries Slower                       │          0 │
│ Queries with No Change               │          7 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃        HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │     1.90 ms │               1.99 ms │     no change │
│ QQuery 1  │    51.41 ms │              48.29 ms │ +1.06x faster │
│ QQuery 2  │   131.77 ms │             152.14 ms │  1.15x slower │
│ QQuery 3  │   155.01 ms │             158.98 ms │     no change │
│ QQuery 4  │  1055.83 ms │            1051.36 ms │     no change │
│ QQuery 5  │  1377.81 ms │            1358.01 ms │     no change │
│ QQuery 6  │     1.85 ms │               1.88 ms │     no change │
│ QQuery 7  │    55.38 ms │              53.52 ms │     no change │
│ QQuery 8  │  1414.97 ms │            1414.03 ms │     no change │
│ QQuery 9  │  1727.45 ms │            1761.27 ms │     no change │
│ QQuery 10 │   350.89 ms │             327.56 ms │ +1.07x faster │
│ QQuery 11 │   393.23 ms │             380.41 ms │     no change │
│ QQuery 12 │  1246.96 ms │            1283.76 ms │     no change │
│ QQuery 13 │  1905.87 ms │            1910.83 ms │     no change │
│ QQuery 14 │  1246.76 ms │            1239.18 ms │     no change │
│ QQuery 15 │  1206.89 ms │            1196.22 ms │     no change │
│ QQuery 16 │  2505.77 ms │            2469.46 ms │     no change │
│ QQuery 17 │  2466.85 ms │            2431.93 ms │     no change │
│ QQuery 18 │  5420.32 ms │            4728.28 ms │ +1.15x faster │
│ QQuery 19 │   122.59 ms │             117.56 ms │     no change │
│ QQuery 20 │  1949.14 ms │            1879.94 ms │     no change │
│ QQuery 21 │  2204.24 ms │            2165.04 ms │     no change │
│ QQuery 22 │  3824.13 ms │            3704.93 ms │     no change │
│ QQuery 23 │ 19858.03 ms │           11959.88 ms │ +1.66x faster │
│ QQuery 24 │   210.20 ms │             211.33 ms │     no change │
│ QQuery 25 │   480.48 ms │             485.99 ms │     no change │
│ QQuery 26 │   236.85 ms │             206.65 ms │ +1.15x faster │
│ QQuery 27 │  2717.47 ms │            2644.42 ms │     no change │
│ QQuery 28 │ 24033.83 ms │           23433.66 ms │     no change │
│ QQuery 29 │   944.06 ms │             995.93 ms │  1.05x slower │
│ QQuery 30 │  1289.01 ms │            1241.06 ms │     no change │
│ QQuery 31 │  1360.64 ms │            1293.42 ms │     no change │
│ QQuery 32 │  4388.88 ms │            4768.02 ms │  1.09x slower │
│ QQuery 33 │  5711.85 ms │            5803.98 ms │     no change │
│ QQuery 34 │  6116.99 ms │            6077.44 ms │     no change │
│ QQuery 35 │  1914.39 ms │            1905.15 ms │     no change │
│ QQuery 36 │    65.95 ms │              68.27 ms │     no change │
│ QQuery 37 │    45.91 ms │              46.92 ms │     no change │
│ QQuery 38 │    66.97 ms │              68.04 ms │     no change │
│ QQuery 39 │   101.20 ms │             100.47 ms │     no change │
│ QQuery 40 │    26.68 ms │              27.95 ms │     no change │
│ QQuery 41 │    22.65 ms │              22.78 ms │     no change │
│ QQuery 42 │    21.01 ms │              20.25 ms │     no change │
└───────────┴─────────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃             ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 100430.08ms │
│ Total Time (test_upgrade_coalesce)   │  91218.19ms │
│ Average Time (HEAD)                  │   2335.58ms │
│ Average Time (test_upgrade_coalesce) │   2121.35ms │
│ Queries Faster                       │           5 │
│ Queries Slower                       │           3 │
│ Queries with No Change               │          35 │
│ Queries with Failure                 │           0 │
└──────────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 109.41 ms │             110.93 ms │     no change │
│ QQuery 2  │  32.55 ms │              31.76 ms │     no change │
│ QQuery 3  │  40.25 ms │              37.99 ms │ +1.06x faster │
│ QQuery 4  │  31.59 ms │              31.23 ms │     no change │
│ QQuery 5  │  91.25 ms │              81.61 ms │ +1.12x faster │
│ QQuery 6  │  20.85 ms │              20.61 ms │     no change │
│ QQuery 7  │ 156.40 ms │             147.16 ms │ +1.06x faster │
│ QQuery 8  │  39.69 ms │              38.55 ms │     no change │
│ QQuery 9  │ 104.74 ms │              97.96 ms │ +1.07x faster │
│ QQuery 10 │  68.92 ms │              61.42 ms │ +1.12x faster │
│ QQuery 11 │  18.77 ms │              18.55 ms │     no change │
│ QQuery 12 │  51.81 ms │              48.99 ms │ +1.06x faster │
│ QQuery 13 │  47.91 ms │              47.87 ms │     no change │
│ QQuery 14 │  15.04 ms │              14.47 ms │     no change │
│ QQuery 15 │  30.60 ms │              28.97 ms │ +1.06x faster │
│ QQuery 16 │  29.45 ms │              27.48 ms │ +1.07x faster │
│ QQuery 17 │ 143.89 ms │             139.14 ms │     no change │
│ QQuery 18 │ 287.46 ms │             259.84 ms │ +1.11x faster │
│ QQuery 19 │  38.66 ms │              38.29 ms │     no change │
│ QQuery 20 │  57.96 ms │              56.69 ms │     no change │
│ QQuery 21 │ 195.31 ms │             181.96 ms │ +1.07x faster │
│ QQuery 22 │  22.94 ms │              21.67 ms │ +1.06x faster │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1635.45ms │
│ Total Time (test_upgrade_coalesce)   │ 1543.13ms │
│ Average Time (HEAD)                  │   74.34ms │
│ Average Time (test_upgrade_coalesce) │   70.14ms │
│ Queries Faster                       │        11 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        11 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (6e1c407) to 3d90d4b diff using: tpcds
Results will be posted here when complete

@alamb-ghbot
Copy link

Benchmark script failed with exit code 101.

Last 10 lines of output:

Click to expand
IndexIterator exhausted early

thread 'tokio-runtime-worker' (2007650) panicked at /home/alamb/.cargo/git/checkouts/arrow-rs-c4799f5fcc4dacb5/9aaca1f/arrow-select/src/filter.rs:107:41:
IndexIterator exhausted early

thread 'tokio-runtime-worker' (2007648) panicked at /home/alamb/.cargo/git/checkouts/arrow-rs-c4799f5fcc4dacb5/9aaca1f/arrow-select/src/filter.rs:107:41:
IndexIterator exhausted early

thread 'tokio-runtime-worker' (2007652) panicked at /home/alamb/.cargo/git/checkouts/arrow-rs-c4799f5fcc4dacb5/9aaca1f/arrow-select/src/filter.rs:107:41:
IndexIterator exhausted early

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (6e1c407) to 3d90d4b diff using: tpch
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 184.97 ms │             191.57 ms │     no change │
│ QQuery 2  │  88.32 ms │              88.01 ms │     no change │
│ QQuery 3  │ 126.89 ms │             120.32 ms │ +1.05x faster │
│ QQuery 4  │  78.60 ms │              77.41 ms │     no change │
│ QQuery 5  │ 176.50 ms │             167.71 ms │     no change │
│ QQuery 6  │  65.69 ms │              66.05 ms │     no change │
│ QQuery 7  │ 215.77 ms │             199.14 ms │ +1.08x faster │
│ QQuery 8  │ 178.54 ms │             169.97 ms │     no change │
│ QQuery 9  │ 236.96 ms │             230.01 ms │     no change │
│ QQuery 10 │ 191.62 ms │             180.01 ms │ +1.06x faster │
│ QQuery 11 │  63.30 ms │              61.43 ms │     no change │
│ QQuery 12 │ 119.64 ms │             118.48 ms │     no change │
│ QQuery 13 │ 216.74 ms │             225.73 ms │     no change │
│ QQuery 14 │  91.69 ms │              92.42 ms │     no change │
│ QQuery 15 │ 126.42 ms │             120.03 ms │ +1.05x faster │
│ QQuery 16 │  61.44 ms │              59.94 ms │     no change │
│ QQuery 17 │ 267.73 ms │             284.62 ms │  1.06x slower │
│ QQuery 18 │ 314.05 ms │             310.95 ms │     no change │
│ QQuery 19 │ 134.38 ms │             134.45 ms │     no change │
│ QQuery 20 │ 130.69 ms │             124.17 ms │     no change │
│ QQuery 21 │ 264.95 ms │             243.01 ms │ +1.09x faster │
│ QQuery 22 │  39.71 ms │              39.04 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 3374.61ms │
│ Total Time (test_upgrade_coalesce)   │ 3304.48ms │
│ Average Time (HEAD)                  │  153.39ms │
│ Average Time (test_upgrade_coalesce) │  150.20ms │
│ Queries Faster                       │         5 │
│ Queries Slower                       │         1 │
│ Queries with No Change               │        16 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing test_upgrade_coalesce (6e1c407) to 3d90d4b diff using: tpch_mem
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and test_upgrade_coalesce
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃      HEAD ┃ test_upgrade_coalesce ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │ 104.16 ms │             112.82 ms │  1.08x slower │
│ QQuery 2  │  32.32 ms │              30.93 ms │     no change │
│ QQuery 3  │  39.75 ms │              39.81 ms │     no change │
│ QQuery 4  │  31.08 ms │              30.57 ms │     no change │
│ QQuery 5  │  91.08 ms │              82.71 ms │ +1.10x faster │
│ QQuery 6  │  20.85 ms │              20.51 ms │     no change │
│ QQuery 7  │ 155.17 ms │             148.12 ms │     no change │
│ QQuery 8  │  41.89 ms │              39.70 ms │ +1.06x faster │
│ QQuery 9  │  96.19 ms │              97.06 ms │     no change │
│ QQuery 10 │  68.58 ms │              61.19 ms │ +1.12x faster │
│ QQuery 11 │  18.12 ms │              18.06 ms │     no change │
│ QQuery 12 │  51.41 ms │              49.81 ms │     no change │
│ QQuery 13 │  47.41 ms │              46.89 ms │     no change │
│ QQuery 14 │  14.83 ms │              14.08 ms │ +1.05x faster │
│ QQuery 15 │  30.59 ms │              29.08 ms │     no change │
│ QQuery 16 │  29.21 ms │              27.80 ms │     no change │
│ QQuery 17 │ 143.02 ms │             142.45 ms │     no change │
│ QQuery 18 │ 285.37 ms │             264.71 ms │ +1.08x faster │
│ QQuery 19 │  39.32 ms │              39.42 ms │     no change │
│ QQuery 20 │  57.29 ms │              57.93 ms │     no change │
│ QQuery 21 │ 188.72 ms │             180.12 ms │     no change │
│ QQuery 22 │  22.09 ms │              21.69 ms │     no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1608.44ms │
│ Total Time (test_upgrade_coalesce)   │ 1555.45ms │
│ Average Time (HEAD)                  │   73.11ms │
│ Average Time (test_upgrade_coalesce) │   70.70ms │
│ Queries Faster                       │         5 │
│ Queries Slower                       │         1 │
│ Queries with No Change               │        16 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants