doc: fix benchmark examples for MacOS - #5522
Merged
Merged
Conversation
regression in documentation after apache#2418
sunchao
approved these changes
Aug 28, 2026
sunchao
left a comment
sunchao
left a comment
Member
There was a problem hiding this comment.
Reviewed the three-line correction at 6f5dfa3. No P1/P2 findings in this change. The export now assigns BENCH_DATA, and both benchmark commands point at the directory containing the generated <table>.parquet files.
Checked the path contract against tpchgen-cli 3.0.0 and the benchmark reader, alongside bounded Bash/dash/zsh controls on Linux and static checks. No data generation, Spark/Comet benchmark, or macOS execution was performed. The CI workflows remain action_required; this review does not claim a CI pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression in example documentation after #2418