chore: bench additional math function - #5520
Open
coderfender wants to merge 2 commits into
Open
Conversation
coderfender
changed the title
sunchao
approved these changes
Aug 28, 2026
sunchao
left a comment
sunchao
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete change at 5bf3c4e: the modulo and negation benchmarks, Cargo registration, and additive exports. No actionable P1/P2 issue found.
Both new Criterion targets linked and passed all 18 smoke cases using unchanged crate sources in a private reduced workspace. A separate correctness control checked every valid Int64 output value and every null position. These are smoke and correctness results, not performance measurements or a full Spark/JNI integration run.
Member
|
@coderfender can you rebase this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5396
Rationale for this change
Add benches/modulo.rs benches/negative.rs. With this, all native Comet math_funcs kernels have criterion coverage
What changes are included in this PR?
How are these changes tested?
Benchmark-only, no behavior change