test: cover invalid unhex inputs in SQL file tests#4890
Open
andygrove wants to merge 1 commit into
Open
Conversation
Add coverage for unhex('-123') and unhex('\0') to the unhex SQL file
tests. Both a non-hex string and the null character exercise unhex's
invalid-input handling, which returns NULL in Spark. The values are
added to the column-path INSERT data and to a dedicated literal query
so both evaluation paths are checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. This is a test-only coverage improvement.
Rationale for this change
The
unhexSQL file tests did not exercise a couple of invalid-input cases.unhexreturns NULL when its argument contains non-hex characters or a null character, and Comet should match Spark for these. Adding explicit cases guards this behavior against regressions.What changes are included in this PR?
Adds coverage for
unhex('-123')(contains a non-hex character) andunhex('\0')(the null character) tospark/src/test/resources/sql-tests/expressions/string/unhex.sql. The values are added both to the column-path INSERT data and to a dedicated literal query so both evaluation paths are checked.How are these changes tested?
./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite unhex" -Dtest=nonepasses; Comet runs both new cases natively and matches Spark (both return NULL).