chore: upgrade to DataFusion main + arrow/parquet 59.1.0 [WIP]#4888
Draft
andygrove wants to merge 2 commits into
Draft
chore: upgrade to DataFusion main + arrow/parquet 59.1.0 [WIP]#4888andygrove wants to merge 2 commits into
andygrove wants to merge 2 commits into
Conversation
2 tasks
Contributor
|
related to #4865 |
Work through the compile breakage surfaced by pinning DataFusion to main: - Drop opt_filter from GroupsAccumulator::merge_batch impls and their delegating call sites (avg, avg_decimal, correlation, covariance, percentile, stddev, sum_decimal, sum_int, variance, merge_as_partial) to match the upstream signature change. - Migrate MutableArrayData::extend/extend_nulls to try_extend/ try_extend_nulls across array_funcs and copy.rs (arrow 59 returns a Result instead of panicking). - Rewire shuffle spill to the new DiskManager API, where create_tmp_file returns Arc<dyn SpillFile> and path() returns Option<&Path>. - Replace deprecated TableSchema::from_file_schema/with_table_partition_cols with the TableSchema builder. - Use FixedSizeBinaryArray::try_from (arrow 59 dropped the From impl). The native iceberg scan remains broken: iceberg-rust still depends on arrow 58, so its RecordBatch does not unify with Comet's arrow 59 type. This is blocked on iceberg-rust upgrading to arrow 59.
andygrove
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP draft to track the upgrade to DataFusion main (currently pinned to
63e25c15bc72e731c174ba03d1143b243cc1aaae, dated 2026-07-10). Bumps arrow/parquet from 58.3.0 to 59.1.0 to match what DataFusion main uses.object_storestays at 0.13.2 (DF main is still on that).Not ready for merge — opened as a draft so CI runs against latest DF main and breaking changes are surfaced continuously.
Changes so far
native/Cargo.toml: swapdatafusion,datafusion-datasource,datafusion-physical-expr-adapter,datafusion-sparkfrom crates.io54.0.0togit = "https://github.com/apache/datafusion", rev = "..."native/core/Cargo.toml: same treatment for the dev-dependencydatafusion-functions-nestedarrowandparquetworkspace pins to59.1.0Known breakage (initial cargo check)
GroupsAccumulator::merge_batchsignature changed upstream — dropped theopt_filter: Option<&BooleanArray>parameter (now 3 args instead of 4). 15 compile errors across:spark-expr/src/agg_funcs/{avg,avg_decimal,correlation,covariance,percentile,stddev,sum_decimal,sum_int,variance}.rsAlso deprecation warnings on
MutableArrayData::extend/extend_nulls(arrow 59 renamed totry_extend/try_extend_nullsreturning errors instead of panicking) across severalspark-expr/src/array_funcs/*.rsfiles.Test plan
cd native && cargo check --workspacecompiles cleanmake test-rustpassesmake test-jvmpasses on default profile