feat: Support Spark expression minutes_of_time#3447
Draft
0lai0 wants to merge 3 commits intoapache:mainfrom
Draft
feat: Support Spark expression minutes_of_time#34470lai0 wants to merge 3 commits intoapache:mainfrom
0lai0 wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3127
Rationale for this change
Comet previously did not support the Spark
MinutesOfTimeexpression, so queries using minute(time_expr) could fall back to JVM execution instead of running natively.What changes are included in this PR?
This change adds a Serde handler for
MinutesOfTimethat reuses the existingMinuteprotobuf and Rust implementation, ensuring consistent behavior while avoiding new native code paths.How are these changes tested?
Added a Scala unit test
MinutesOfTime expression supportinCometExpressionSuite