CXF-9233: AbstractLoggingInterceptor.LIVE_LOGGING_PROP already set in the message properties, so RESP_OUT is not logged - #3372
Open
reta wants to merge 3 commits into
Open
CXF-9233: AbstractLoggingInterceptor.LIVE_LOGGING_PROP already set in the message properties, so RESP_OUT is not logged#3372reta wants to merge 3 commits into
reta wants to merge 3 commits into
Conversation
… the message properties, so RESP_OUT is not logged
There was a problem hiding this comment.
Pull request overview
This PR addresses a logging regression where AbstractLoggingInterceptor.LIVE_LOGGING_PROP can be copied between related CXF Message instances (e.g., request→response), causing the RESP_OUT event to be incorrectly treated as “already logged” and therefore skipped.
Changes:
- Namespace the “already logged” marker property by adding a suffix to
LIVE_LOGGING_PROPwhen storing/reading it. - Add/extend regression tests for REST proxy clients and JAX-WS local-transport scenarios to validate all four expected logging events.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/TestServiceRest.java | Refactors the test resource implementation to implement a shared annotated contract interface. |
| rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/TestService.java | Introduces a JAX-RS annotated contract interface used by proxy-based tests. |
| rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/RESTLoggingTest.java | Adds a proxy-client regression test and a helper to create typed proxy clients with logging enabled. |
| rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/JaxWsClientTest.java | Adds a local-transport JAX-WS test that captures log events to validate the fix in SOAP client flows. |
| rt/features/logging/src/main/java/org/apache/cxf/ext/logging/LoggingOutInterceptor.java | Writes the “already logged” marker using a suffixed property key. |
| rt/features/logging/src/main/java/org/apache/cxf/ext/logging/LoggingInInterceptor.java | Writes the “already logged” marker using a suffixed property key. |
| rt/features/logging/src/main/java/org/apache/cxf/ext/logging/AbstractLoggingInterceptor.java | Updates the contextual-property lookup for the marker key and adds a suffix helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that
ClientImpl::onMessagemay create in-message (response) from the out message (request), copying the contextual properties but changing the message requestor role. That would lead to logging interceptor to mistakenly mark that the message as already logged.