CURATOR-676: Notify CuratorListener for retriable errors when no callback specified - #1300
Open
waterWang wants to merge 1 commit into
Open
CURATOR-676: Notify CuratorListener for retriable errors when no callback specified#1300waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…back specified When abortOperation is called for a retriable error and no BackgroundCallback was specified on the operation, CuratorListener was silently ignored. Now it properly falls back to notifying all registered CuratorListeners via processEvent(), matching the documented behavior that CuratorListener is a catch-all fallback for BackgroundCallback. Fixes apache#1191
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
abortOperationis called for a retriable error and noBackgroundCallbackwas specified on the operation, theCuratorListenerwas silently ignored (the method returned early atif (operation.getCallback() == null) { return; }).According to the documented behavior,
CuratorListeneris a catch-all fallback forBackgroundCallbackwhen no callback is specified at the operation level. This fix ensures that theCuratorListeneris properly notified viaprocessEvent()in this case.Changes
In
CuratorFrameworkImpl.abortOperation():callback == null, callprocessEvent(event)to notify all registeredCuratorListenerinstancescallback != null, continue to callsendToBackgroundCallback(operation, event)as beforeFixes #1191