Skip to content

Add ROOT CAs to the trust store #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vishesh92 wants to merge 12 commits into
base: main
Choose a base branch
from

fixups

6adca9a
Select commit
Loading
Failed to load commit list.
Draft

Add ROOT CAs to the trust store #12911

fixups
6adca9a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 3, 2026 in 0s

18.01% (-0.01%) compared to 1bff543

View this Pull Request on Codecov

18.01% (-0.01%) compared to 1bff543

Details

Codecov Report

❌ Patch coverage is 37.14286% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (1bff543) to head (6adca9a).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/apache/cloudstack/ca/CAManagerImpl.java 42.47% 56 Missing and 9 partials ⚠️
.../apache/cloudstack/ca/provider/RootCAProvider.java 13.63% 37 Missing and 1 partial ⚠️
.../api/command/admin/ca/ProvisionCertificateCmd.java 0.00% 4 Missing ⚠️
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 0.00% 1 Missing ⚠️
utils/src/main/java/com/cloud/utils/nio/Link.java 0.00% 1 Missing ⚠️
...rg/apache/cloudstack/utils/security/CertUtils.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12911      +/-   ##
============================================
- Coverage     18.02%   18.01%   -0.01%     
- Complexity    16460    16474      +14     
============================================
  Files          5968     5977       +9     
  Lines        537213   537851     +638     
  Branches      65975    66049      +74     
============================================
+ Hits          96825    96907      +82     
- Misses       429469   430013     +544     
- Partials      10919    10931      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov