Skip to content

[4.22] Prevent unmanaging VM from CloudStack if it is part of a CKS cluster#12800

Open
nvazquez wants to merge 3 commits intoapache:4.22from
shapeblue:422-fix-cks-node-unmanage-vm
Open

[4.22] Prevent unmanaging VM from CloudStack if it is part of a CKS cluster#12800
nvazquez wants to merge 3 commits intoapache:4.22from
shapeblue:422-fix-cks-node-unmanage-vm

Conversation

@nvazquez
Copy link
Contributor

Description

This PR prevents unmanaging a VM from CloudStack if it belongs to a CKS cluster

Fixes: #12783

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (09ee092) to head (8935377).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12800   +/-   ##
=========================================
  Coverage     17.61%   17.61%           
- Complexity    15661    15667    +6     
=========================================
  Files          5917     5917           
  Lines        531423   531428    +5     
  Branches      64973    64974    +1     
=========================================
+ Hits          93586    93601   +15     
+ Misses       427280   427272    -8     
+ Partials      10557    10555    -2     
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiranchavala kiranchavala self-assigned this Mar 12, 2026
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17119

@nvazquez
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-15632)

@nvazquez
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-15633)

@kiranchavala
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-15649)

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez nvazquez closed this Mar 13, 2026
@nvazquez nvazquez reopened this Mar 13, 2026
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17137

@nvazquez
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-15651)

Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvazquez

Unable to deploy systemvm's with the pr packages

Getting the following exceptions

2026-03-16 05:00:29,098 ERROR [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-2:[ctx-1d43103b, job-15992/job-15994, ctx-46eb4f82]) (logid:f4bd0cb7) Invocation exception, caused by: java.lang.NullPointerException: Cannot invoke "com.cloud.hypervisor.HypervisorGuru.implement(com.cloud.vm.VirtualMachineProfile)" because "hvGuru" is null
2026-03-16 05:00:29,098 INFO  [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-2:[ctx-1d43103b, job-15992/job-15994, ctx-46eb4f82]) (logid:f4bd0cb7) Rethrow exception java.lang.NullPointerException: Cannot invoke "com.cloud.hypervisor.HypervisorGuru.implement(com.cloud.vm.VirtualMachineProfile)" because "hvGuru" is null
2026-03-16 05:00:29,098 DEBUG [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-2:[ctx-1d43103b, job-15992/job-15994]) (logid:f4bd0cb7) Done with run of VM work job: com.cloud.vm.VmWorkStart for VM 4, job origin: 15992
2026-03-16 05:00:29,098 ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-2:[ctx-1d43103b, job-15992/job-15994]) (logid:f4bd0cb7) Unable to complete AsyncJob {"accountId":1,"cmd":"com.cloud.vm.VmWorkStart","cmdInfo":"rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAAAAAAAAAABAAAAAAAAAAEAAAAAAAAABHQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAAHBwcHBwcHBwcHA","cmdVersion":0,"completeMsid":null,"created":"Mon Mar 16 05:00:23 UTC 2026","id":15994,"initMsid":32985667600753,"instanceId":null,"instanceType":null,"lastPolled":null,"lastUpdated":null,"processStatus":0,"removed":null,"result":null,"resultCode":0,"status":"IN_PROGRESS","userId":1,"uuid":"509eb5a5-24e5-4bc3-b0e2-71b170c42f2f"}, job origin: 15992 java.lang.NullPointerException: Cannot invoke "com.cloud.hypervisor.HypervisorGuru.implement(com.cloud.vm.VirtualMachineProfile)" because "hvGuru" is null

2026-03-16 05:00:29,124 WARN  [c.c.c.ConsoleProxyManagerImpl] (consoleproxy-1:[ctx-c3c3424a]) (logid:6d3a850d) Unable to allocate console proxy standby capacity for zone [Zone {"id": "1", "name": "ref-trl-11326-k-Mol8-kiran-chavala", "uuid": "ebe31a7b-1e2c-4891-b408-2133ce560d8d"}] due to [null]. java.lang.NullPointerException


@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17156

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

CKS cluster goes into alert state when worker node is unmanaged

5 participants