Skip to content

server: prevent adding vm compute details when not applicable#12637

Open
shwstppr wants to merge 7 commits intoapache:4.20from
shapeblue:fix-svcoff-speedcheck
Open

server: prevent adding vm compute details when not applicable#12637
shwstppr wants to merge 7 commits intoapache:4.20from
shapeblue:fix-svcoff-speedcheck

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Feb 12, 2026 •
edited
Loading

Description

cpuNumber, memory and cpuSpeed shouldn't be added for VMs which use fixed offerings. It creates confusion and when adding cpuSpeed as zero for constrained offering which uses limit CPU flag, VM can failed to boot if speed specified is zero or very low.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

When adding for fixed offering,
image

When adding for constrained custom offering,
image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
server: prevent adding of compute details for vm when using fixed off…
56b2ea1 
…ering

cpuNumber, memory and cpuSpeed shouldn't be added for VMs which use
fixed offerings. It creates confusion and when adding cpuSpeed as zero
for constrained offering which uses limit CPU flag, VM can failed to
boot if speed specified is zero or very low.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (6f1aa96) to head (c877fce).

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 37.50% 8 Missing and 12 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #12637   +/-   ##
=========================================
  Coverage     16.26%   16.26%           
- Complexity    13434    13436    +2     
=========================================
  Files          5665     5665           
  Lines        500530   500534    +4     
  Branches      60787    60789    +2     
=========================================
+ Hits          81411    81417    +6     
+ Misses       410028   410014   -14     
- Partials       9091     9103   +12
Flag Coverage Δ
uitests 4.15% <ø> (ø)
unittests 17.11% <37.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Feb 12, 2026
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 12, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 12, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 12, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16812

@abh1sar abh1sar modified the milestones: 4.20.3, 4.20.4 Feb 16, 2026
@shwstppr shwstppr changed the title server: prevent adding of compute details for vm when using fixed offering server: prevent adding of compute details for vm when not applicable Feb 17, 2026
@shwstppr
refactor, test
3322abf 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
fix
e28e177 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Feb 23, 2026
@apache apache deleted a comment from blueorangutan Feb 23, 2026
@shwstppr
explicitly set offering bounds
a84d2d7 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Feb 23, 2026
@apache apache deleted a comment from blueorangutan Feb 23, 2026
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Feb 23, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2026

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2026

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16917

@shwstppr
fix test that sets max cpu, memory globally
2cefcc3 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Feb 24, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2026

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr shwstppr changed the title server: prevent adding of compute details for vm when not applicable server: prevent adding compute details for vm when not applicable Feb 24, 2026
@shwstppr shwstppr changed the title server: prevent adding compute details for vm when not applicable server: prevent adding vm compute details when not applicable Feb 24, 2026
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16928

@shwstppr shwstppr marked this pull request as ready for review February 24, 2026 10:33
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 6, 2026

[LL] Trillian Build Failed (tid-7172)

rajujith
rajujith approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Documentation to follow. cc @shwstppr

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr added a commit to shapeblue/cloudstack-documentation that referenced this pull request Mar 27, 2026
@shwstppr
kvm,compute-offering: prevent CPU limiting completely
b9c04ab 
Related apache/cloudstack#12637

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Mar 27, 2026
Open
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 8, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 8, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 8, 2026

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17396

DaanHoogland
DaanHoogland reviewed Apr 9, 2026
View reviewed changes
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 9, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17417

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 9, 2026

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 9, 2026

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 9, 2026

[SF] Trillian Build Failed (tid-15835)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 10, 2026

[SF] Trillian test result (tid-15837)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49273 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12637-t15837-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rajujith rajujith rajujith approved these changes

Assignees

No one assigned

Labels

status:ready-for-merge

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @DaanHoogland @blueorangutan @rajujith @abh1sar