Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 34 commits into
base: main
Choose a base branch
from
+4,640 −175

support live vm migration between clvm -> clvm-ng (vice-versa), nfs -…

437f77c
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

support live vm migration between clvm -> clvm-ng (vice-versa), nfs -…
437f77c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 24, 2026 in 11m 38s

Quality Gate failed

Failed conditions
1 Security Hotspot
8.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 281 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiV&open=AZycJS_0331ZRqy8rtiV&pullRequest=12617

Check failure on line 986 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "template-" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrU&open=AZz35YeN4256DVCsFLrU&pullRequest=12617

Check warning on line 1238 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrJ&open=AZz35YY_4256DVCsFLrJ&pullRequest=12617

Check failure on line 800 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvl-&open=AZxEJ4RLTdhpX5MPbvl-&pullRequest=12617

Check warning on line 420 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrL&open=AZz35YeN4256DVCsFLrL&pullRequest=12617

Check warning on line 770 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvl8&open=AZxEJ4RLTdhpX5MPbvl8&pullRequest=12617

Check warning on line 43 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZwWi8wmAtCWzk9n&open=AZxykZwWi8wmAtCWzk9n&pullRequest=12617

Check failure on line 469 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZySVt7WZWnQmdcHvGAu&open=AZySVt7WZWnQmdcHvGAu&pullRequest=12617

Check warning on line 42 in server/src/main/java/com/cloud/storage/ClvmLockManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volsDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTXm331ZRqy8rtir&open=AZycJTXm331ZRqy8rtir&pullRequest=12617

Check warning on line 2754 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ0H7qRYrpT77nGx4twU&open=AZ0H7qRYrpT77nGx4twU&pullRequest=12617

Check warning on line 1142 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35Yk94256DVCsFLrq&open=AZz35Yk94256DVCsFLrq&pullRequest=12617

Check warning on line 278 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJS_0331ZRqy8rtiX&open=AZycJS_0331ZRqy8rtiX&pullRequest=12617

Check warning on line 945 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4RLTdhpX5MPbvmD&open=AZxEJ4RLTdhpX5MPbvmD&pullRequest=12617

Check failure on line 275 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZmDi8wmAtCWzk9i&open=AZxykZmDi8wmAtCWzk9i&pullRequest=12617

Check warning on line 46 in server/src/main/java/com/cloud/storage/ClvmLockManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_hostDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTXm331ZRqy8rtit&open=AZycJTXm331ZRqy8rtit&pullRequest=12617

Check warning on line 1134 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrF&open=AZz35YY_4256DVCsFLrF&pullRequest=12617

Check warning on line 1304 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace charset name argument with StandardCharsets.UTF_8 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxEJ4MqTdhpX5MPbvl4&open=AZxEJ4MqTdhpX5MPbvl4&pullRequest=12617

Check warning on line 113 in server/src/test/java/com/cloud/storage/ClvmLockManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTYW331ZRqy8rtiy&open=AZycJTYW331ZRqy8rtiy&pullRequest=12617

Check warning on line 694 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZycJTGW331ZRqy8rtie&open=AZycJTGW331ZRqy8rtie&pullRequest=12617

Check warning on line 1134 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YY_4256DVCsFLrH&open=AZz35YY_4256DVCsFLrH&pullRequest=12617

Check failure on line 3014 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxOattGxHcHLzahJAAA&open=AZxOattGxHcHLzahJAAA&pullRequest=12617

Check warning on line 84 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_storagePoolDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxykZmDi8wmAtCWzk9g&open=AZxykZmDi8wmAtCWzk9g&pullRequest=12617

Check warning on line 1217 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLre&open=AZz35YeN4256DVCsFLre&pullRequest=12617

Check warning on line 2556 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZz35YeN4256DVCsFLrk&open=AZz35YeN4256DVCsFLrk&pullRequest=12617

Check warning on line 129 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPrepareForMigrationCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZxtJVlFJejGTVrNgEqC&open=AZxtJVlFJejGTVrNgEqC&pullRequest=12617
View more details on SonarQubeCloud