Skip to content

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 37 commits into from
May 28, 2025

handle review comments

ba8802f
Select commit
Loading
Failed to load commit list.
Merged

Instance lease: Allow deployment of instances with lease duration and leaseexpiry action #10560

handle review comments
ba8802f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 27, 2025 in 1s

52.91% of diff hit (target 16.52%)

View this Pull Request on Codecov

52.91% of diff hit (target 16.52%)

Annotations

Check warning on line 502 in api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java#L502 

Added line #L502 was not covered by tests

Check warning on line 75 in api/src/main/java/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java#L75 

Added line #L75 was not covered by tests

Check warning on line 488 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L486-L488 

Added lines #L486 - L488 were not covered by tests

Check warning on line 490 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L490 

Added line #L490 was not covered by tests

Check warning on line 492 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L492 

Added line #L492 was not covered by tests

Check warning on line 494 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L494 

Added line #L494 was not covered by tests

Check warning on line 497 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L496-L497 

Added lines #L496 - L497 were not covered by tests

Check warning on line 500 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java#L499-L500 

Added lines #L499 - L500 were not covered by tests

Check warning on line 163 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java#L163 

Added line #L163 was not covered by tests

Check warning on line 166 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java#L166 

Added line #L166 was not covered by tests

Check warning on line 313 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java#L311-L313 

Added lines #L311 - L313 were not covered by tests

Check warning on line 339 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L337-L339 

Added lines #L337 - L339 were not covered by tests

Check warning on line 341 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L341 

Added line #L341 was not covered by tests

Check warning on line 343 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L343 

Added line #L343 was not covered by tests

Check warning on line 345 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L345 

Added line #L345 was not covered by tests

Check warning on line 348 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L347-L348 

Added lines #L347 - L348 were not covered by tests

Check warning on line 351 in api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L350-L351 

Added lines #L350 - L351 were not covered by tests

Check warning on line 257 in api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java#L255-L257 

Added lines #L255 - L257 were not covered by tests

Check warning on line 518 in api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java#L516-L518 

Added lines #L516 - L518 were not covered by tests

Check warning on line 522 in api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java#L520-L522 

Added lines #L520 - L522 were not covered by tests

Check warning on line 526 in api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java#L524-L526 

Added lines #L524 - L526 were not covered by tests

Check warning on line 530 in api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java#L528-L530 

Added lines #L528 - L530 were not covered by tests

Check warning on line 1199 in api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java#L1197-L1199 

Added lines #L1197 - L1199 were not covered by tests

Check warning on line 1203 in api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java#L1201-L1203 

Added lines #L1201 - L1203 were not covered by tests

Check warning on line 1207 in api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java#L1205-L1207 

Added lines #L1205 - L1207 were not covered by tests
View more details on Codecov