-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Test cases for Plc4X consumer. #21306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases for Plc4X consumer. #21306
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
components/camel-plc4x/src/test/java/org/apache/camel/component/plc4x/Plc4XConsumerTest.java
Show resolved
Hide resolved
| public void doStop() { | ||
| void doStop() throws Exception { | ||
| ScheduledFuture<?> future = mock(ScheduledFuture.class); | ||
| var field = Plc4XConsumer.class.getDeclaredField("future"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is reflection really needed?
Is there another way to test it maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by looking at the producer test. hope this is ok.
|
Thanks for your contribution @chandru9 ! |
Description
[x] Unit tests for Plc4X consumer.
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.