Skip to content

Conversation

@chandru9
Copy link
Contributor

@chandru9 chandru9 commented Feb 8, 2026

Description

[x] Unit tests for Plc4X consumer.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

public void doStop() {
void doStop() throws Exception {
ScheduledFuture<?> future = mock(ScheduledFuture.class);
var field = Plc4XConsumer.class.getDeclaredField("future");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is reflection really needed?

Is there another way to test it maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by looking at the producer test. hope this is ok.

@chandru9 chandru9 requested a review from Croway February 11, 2026 02:25
@Croway Croway merged commit 8b22e94 into apache:main Feb 11, 2026
6 checks passed
@Croway
Copy link
Contributor

Croway commented Feb 11, 2026

Thanks for your contribution @chandru9 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants