[CALCITE-7082] CalciteSystemProperty saffron.properties lookup is unusual#4455
[CALCITE-7082] CalciteSystemProperty saffron.properties lookup is unusual#4455chrisdennis wants to merge 1 commit intoapache:mainfrom
Conversation
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
To concrete things up this is what I'm suggesting as a new approach for CALCITE-7082. This implementation should (although nothing is tested) make sure that each property follows a simple priority model. Highest priority setting wins along the list:
saffron.propertiesentry inThread.currentThread().getContextClassLoader()(TCCL) accessible resource.saffron.propertiesentry inCalciteSystemPropery.class.getClassLoader()accessible resource.For comparison the current implementation is either, with a TCCL set when Calcite is first loaded:
saffron.propertiesentry insaffron.propertiesavailable via TCCL.with no TCCL set when Calcite is first loaded:
saffron.propertiesentry insaffron.propertiesavailable via Calcite loader.