-
Notifications
You must be signed in to change notification settings - Fork 4.1k
support SO_BINDTODEVICE and bind client_host #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2578b05
bind_client_ip
wenjiecn 4aac92d
fix UT & review
wenjiecn 1bff8cb
add client_host UT
wenjiecn 8650f00
updated to support SO_BINDTODEVICE.
wenjiecn df18000
updated to support SO_BINDTODEVICE and bind client_host.
wenjiecn 46b8adf
review
wenjiecn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -728,7 +728,7 @@ int Socket::OnCreated(const SocketOptions& options) { | |||||
| _keytable_pool = options.keytable_pool; | ||||||
| _tos = 0; | ||||||
| _remote_side = options.remote_side; | ||||||
| _local_side = butil::EndPoint(); | ||||||
| _local_side = options.local_side; | ||||||
| _on_edge_triggered_events = options.on_edge_triggered_events; | ||||||
| _user = options.user; | ||||||
| _conn = options.conn; | ||||||
|
|
@@ -1283,8 +1283,10 @@ int Socket::Connect(const timespec* abstime, | |||||
| _ssl_state = SSL_OFF; | ||||||
| } | ||||||
| struct sockaddr_storage serv_addr; | ||||||
| struct sockaddr_storage cli_addr; | ||||||
| socklen_t addr_size = 0; | ||||||
| if (butil::endpoint2sockaddr(remote_side(), &serv_addr, &addr_size) != 0) { | ||||||
| if (butil::endpoint2sockaddr(remote_side(), &serv_addr, &addr_size) != 0 || | ||||||
| butil::endpoint2sockaddr(local_side(), &cli_addr, &addr_size) != 0) { | ||||||
|
wenjiecn marked this conversation as resolved.
Outdated
wenjiecn marked this conversation as resolved.
Outdated
|
||||||
| PLOG(ERROR) << "Fail to get sockaddr"; | ||||||
| return -1; | ||||||
| } | ||||||
|
|
@@ -1297,6 +1299,10 @@ int Socket::Connect(const timespec* abstime, | |||||
| // We need to do async connect (to manage the timeout by ourselves). | ||||||
| CHECK_EQ(0, butil::make_non_blocking(sockfd)); | ||||||
|
|
||||||
| if (::bind(sockfd, (struct sockaddr*)& cli_addr, addr_size) != 0) { | ||||||
|
wenjiecn marked this conversation as resolved.
Outdated
|
||||||
| if (::bind(sockfd, (struct sockaddr*)& cli_addr, addr_size) != 0) { | |
| if (::bind(sockfd, (struct sockaddr*)&cli_addr, addr_size) != 0) { |
wenjiecn marked this conversation as resolved.
Outdated
wenjiecn marked this conversation as resolved.
Outdated
wenjiecn marked this conversation as resolved.
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.