Support IBM MQ for Python JmsIO - #39467
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
b79ee1c to
ff52839
Compare
ff52839 to
8edf305
Compare
| /** A POJO describing a JMS connection. */ | ||
| @DefaultSchema(AutoValueSchema.class) | ||
| @AutoValue | ||
| public abstract static class ConnectionConfiguration implements Serializable { |
There was a problem hiding this comment.
Safe to move as it does not exist in any released version yet
8edf305 to
1a2a03e
Compare
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
* Introduce a BeamGenericJmsConnectionFactory interface to support different Jms JmsConnectionFactory cross-lang * Move ConnectionConfiguration outside of JmsIO class * Add test case for IBM MQ
1a2a03e to
d1af5d0
Compare
Introduce a BeamGenericJmsConnectionFactory interface to support
different Jms JmsConnectionFactory cross-lang
Move ConnectionConfiguration outside of JmsIO class
Add test case for IBM MQ
Fix #30716
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.