Skip to content

Update go dependencies#38530

Open
joesantos418 wants to merge 3 commits into
apache:masterfrom
joesantos418:master
Open

Update go dependencies#38530
joesantos418 wants to merge 3 commits into
apache:masterfrom
joesantos418:master

Conversation

@joesantos418
Copy link
Copy Markdown

@joesantos418 joesantos418 commented May 18, 2026

Update all go dependencies, including github.com/docker/docker which was replaced by github.com/moby/moby

Summary of Changes

I've successfully updated the file to use the new github.com/moby/moby/client package API instead of the deprecated github.com/docker/docker package. Here are the key changes:

  1. Removed unused import: Removed "github.com/moby/moby/api/types/image" as it's no longer needed.

  2. Updated ImageInspectWithRawImageInspect: Changed from the old 3-return-value method to the new 2-return-value method.

  3. Updated ImagePull: Changed from image.PullOptions{} to dcli.ImagePullOptions{}.

  4. Updated ContainerCreate: Changed from multiple parameters to a single dcli.ContainerCreateOptions struct that contains both Config and HostConfig.

  5. Updated ContainerStart: Changed from container.StartOptions{} to dcli.ContainerStartOptions{}, and handled the fact that it now returns 2 values instead of 1.

  6. Updated ContainerWait: The new API returns a ContainerWaitResult directly instead of separate status and error channels. Rewrote the logic to use a goroutine and a done channel to handle both cases (context cancellation and container self-termination).

  7. Updated ContainerLogs: Changed from container.LogsOptions to dcli.ContainerLogsOptions.

  8. Updated ContainerKill: Changed to use dcli.ContainerKillOptions{} and handle the 2 return values.

All changes maintain the original behavior while using the new API from the github.com/moby/moby/client package.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Go dependencies, most notably migrating from the deprecated github.com/docker/docker package to the current github.com/moby/moby/client library. This change required refactoring several Docker-related operations to accommodate the new API signatures and structures. Additionally, various other project dependencies were updated to ensure compatibility and security.

Highlights

  • Dependency Migration: Migrated from the deprecated github.com/docker/docker package to the current github.com/moby/moby/client library.
  • API Refactoring: Updated Docker client operations including ImageInspect, ContainerCreate, ContainerStart, ContainerWait, ContainerLogs, and ContainerKill to match the new Moby API signatures.
  • Dependency Updates: Updated various Go dependencies in go.mod and go.sum to ensure compatibility and maintain project health.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a major dependency update, specifically migrating the Docker client implementation from github.com/docker/docker to github.com/moby/moby. The environments.go file was updated to accommodate the new API, including changes to container creation, starting, and a new asynchronous wait mechanism for container termination. Review feedback highlights that removing API version negotiation may cause compatibility issues and notes that the new logging logic for container termination is misleading and redundant.

Comment thread sdks/go/pkg/beam/runners/prism/internal/environments.go
Comment thread sdks/go/pkg/beam/runners/prism/internal/environments.go Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@joesantos418
Copy link
Copy Markdown
Author

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @jrmccluskey for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Update all go dependencies, including github.com/docker/docker which was
replaced by github.com/moby/moby
Improves logging logic according to the review points raised by copilot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant