Cherrypick #37668

[Amar3tto]

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Milvus integration tests by making the pymilvus dependency optional. It refactors the import mechanism and test execution logic to gracefully handle environments where pymilvus might not be installed, ensuring that the overall test suite can still run without encountering ImportError exceptions.

Highlights

• Conditional pymilvus Imports: Refactored the pymilvus library imports within the Milvus integration test file to be conditional. These imports are now wrapped in a try-except ImportError block, allowing the test file to load even if pymilvus is not installed.
• Introduced PYMILVUS_AVAILABLE Flag: A new boolean flag, PYMILVUS_AVAILABLE, was added. This flag is set to True if the pymilvus imports succeed and False otherwise, providing a clear indicator of the library's presence.
• Conditional Test Execution: Modified the test_milvus_vector_writer function to use the @unittest.skipIf decorator. This ensures that the Milvus integration test is skipped if pymilvus is not available, preventing test failures due to missing dependencies and improving test suite robustness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/ml/rag/ingestion/milvus_search_it_test.py
  • Refactored pymilvus imports to be conditional, moving them into a try-except ImportError block.
  • Introduced a PYMILVUS_AVAILABLE flag to track the presence of the pymilvus library.
  • Added a @unittest.skipIf decorator to the Milvus integration test, allowing it to be skipped if pymilvus is not installed.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Abacn]

actually, lint precommit failing on this change:

https://github.com/apache/beam/actions/runs/23004692106/job/66798155194?pr=37834

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.86%. Comparing base (3d11a05) to head (1ee624f).
⚠️ Report is 29 commits behind head on release-2.72.

Additional details and impacted files

@@                Coverage Diff                 @@
##             release-2.72   #37834      +/-   ##
==================================================
- Coverage           57.00%   56.86%   -0.14%     
  Complexity           3416     3416              
==================================================
  Files                1178     1178              
  Lines              187378   187381       +3     
  Branches             3588     3588              
==================================================
- Hits               106810   106558     -252     
- Misses              77178    77433     +255     
  Partials             3390     3390              

Flag	Coverage Δ
python	80.09% <100.00%> (-0.33%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Amar3tto]

actually, lint precommit failing on this change:

https://github.com/apache/beam/actions/runs/23004692106/job/66798155194?pr=37834

fixed