GH-50911: [C++][FlightSQL][ODBC] Replace RapidJSON with JsonWriter - #50912
Merged
Conversation
Reranko05
force-pushed
the
gh-35460-flight
branch
from
August 19, 2026 16:12
82a2c8b to
24a11ad
Compare
Reranko05
force-pushed
the
gh-35460-flight
branch
from
August 19, 2026 16:27
24a11ad to
6957733
Compare
Reranko05
marked this pull request as ready for review
August 19, 2026 17:09
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit fc3be9e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing the remaining RapidJSON usage in the FlightSQL ODBC JSON converter with Arrow's existing
JsonWriter.Changes
rapidjson::Writerandrapidjson::StringBufferwitharrow::json::JsonWriter.SizeTypeusage with theJsonWriterinterface.RawValueusage withJsonWriter::RawValue.ConvertToJsonbehavior and test coverage.