Skip to content

GH-39026: [C++][Python] Add ARROW_HARDENING compiler options - #50902

Draft
raulcd wants to merge 4 commits into
apache:mainfrom
raulcd:GH-39026
Draft

GH-39026: [C++][Python] Add ARROW_HARDENING compiler options#50902
raulcd wants to merge 4 commits into
apache:mainfrom
raulcd:GH-39026

Conversation

@raulcd

@raulcd raulcd commented Aug 18, 2026

Copy link
Copy Markdown
Member

TBD:

Currently just testing.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@raulcd

raulcd commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-manylinux-2-28-cp314-cp314-amd64

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #39026 has been automatically assigned in GitHub to PR creator.

@github-actions

Copy link
Copy Markdown

Revision: 0ea10af

Submitted crossbow builds: ursacomputing/crossbow @ actions-43e3957538

Task Status
wheel-manylinux-2-28-cp314-cp314-amd64 GitHub Actions

@raulcd

raulcd commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-linux--cp314-cp314*

@github-actions

Copy link
Copy Markdown

Revision: 0ea10af

Submitted crossbow builds: ursacomputing/crossbow @ actions-5df70e9967

Task Status
wheel-manylinux-2-28-cp314-cp314-amd64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314-arm64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314t-amd64 GitHub Actions
wheel-manylinux-2-28-cp314-cp314t-arm64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314-amd64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314-arm64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314t-amd64 GitHub Actions
wheel-musllinux-1-2-cp314-cp314t-arm64 GitHub Actions

@raulcd

raulcd commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@ursabot please benchmark

@rok

rok commented Aug 18, 2026

Copy link
Copy Markdown
Member

Benchmark runs are scheduled for commit d9d991d. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.

@conbench-apache-arrow

Copy link
Copy Markdown

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit d9d991d.

There were 87 benchmark results indicating a performance regression:

The full Conbench report has more details.

@raulcd

raulcd commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

@ursabot please benchmark

@rok

rok commented Aug 19, 2026

Copy link
Copy Markdown
Member

Benchmark runs are scheduled for commit f293a08. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.

…f the performance regression at least locally
@raulcd

raulcd commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

@ursabot please benchmark

@rok

rok commented Aug 19, 2026

Copy link
Copy Markdown
Member

Benchmark runs are scheduled for commit 83d61b9. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.

@conbench-apache-arrow

Copy link
Copy Markdown

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit f293a08.

There were 5 benchmark results indicating a performance regression:

The full Conbench report has more details.

@conbench-apache-arrow

Copy link
Copy Markdown

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 83d61b9.

There were 34 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants