GH-39026: [C++][Python] Add ARROW_HARDENING compiler options - #50902
GH-39026: [C++][Python] Add ARROW_HARDENING compiler options#50902raulcd wants to merge 4 commits into
Conversation
|
@github-actions crossbow submit wheel-manylinux-2-28-cp314-cp314-amd64 |
|
|
|
Revision: 0ea10af Submitted crossbow builds: ursacomputing/crossbow @ actions-43e3957538
|
|
@github-actions crossbow submit wheel-linux--cp314-cp314* |
|
Revision: 0ea10af Submitted crossbow builds: ursacomputing/crossbow @ actions-5df70e9967 |
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit d9d991d. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit d9d991d. There were 87 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit f293a08. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete. |
…f the performance regression at least locally
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit 83d61b9. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete. |
|
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit f293a08. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. |
|
Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit 83d61b9. There were 34 benchmark results indicating a performance regression:
The full Conbench report has more details. |
TBD:
Currently just testing.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)