Skip to content

GH-50133: [CI] Make extra labels entirely manual#50256

Open
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:gh50133-manual-extra-labels
Open

GH-50133: [CI] Make extra labels entirely manual#50256
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:gh50133-manual-extra-labels

Conversation

@pitrou

@pitrou pitrou commented Jun 25, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Our "Extra" labels for CI are currently both manual and automatic:

  • manual, such that a committer can add a label to force an additional of CI jobs to run on a PR
  • automatic, such that specific file changes can also force those additional CI jobs to run

However, the two mechanisms can conflict with each other, when an Extra label is manually added by a committer, but none of the file changes match. The label can then be later removed by the automatic labelling bot.

What changes are included in this PR?

Make the "Extra" labels manual-only.

Are these changes tested?

N/A.

Are there any user-facing changes?

No.

@pitrou pitrou added the CI: Extra: C++ Run extra C++ CI label Jun 25, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #50133 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added awaiting review Awaiting review and removed CI: Extra: C++ Run extra C++ CI labels Jun 25, 2026
@pitrou pitrou added the CI: Extra: C++ Run extra C++ CI label Jun 25, 2026
@pitrou

pitrou commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Ping @raulcd @kou

@pitrou

pitrou commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

"Extra: C++" does not seem to be working as expected here?

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as seen on the other issue, should we also avoid forcing a build if the workflow file has changed?

git diff --stat origin/${GITHUB_BASE_REF}..
if git diff --stat origin/${GITHUB_BASE_REF}.. | \
grep \
--fixed-strings ".github/workflows/${PARENT_WORKFLOW}.yml" \
--quiet; then
echo "force=true" >> "${GITHUB_OUTPUT}"

This might force builds when the PR is old and new changes are merged on main.

@kou what do you think on that case?

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jun 25, 2026
@raulcd

raulcd commented Jun 25, 2026

Copy link
Copy Markdown
Member

"Extra: C++" does not seem to be working as expected here?

doesn't it still require changes on the defined path? We could force check on all (remove the paths as we do for cuda_extra.yml)

    paths:
      - '.dockerignore'
      - '.github/workflows/check_labels.yml'
      - '.github/workflows/cpp_extra.yml'
      - '.github/workflows/cpp_windows.yml'
      - '.github/workflows/report_ci.yml'
      - 'ci/conda_env_*'
      - 'ci/docker/**'
      - 'ci/scripts/ccache_setup.sh'
      - 'ci/scripts/cpp_*'
      - 'ci/scripts/install_azurite.sh'
      - 'ci/scripts/install_gcs_testbench.sh'
      - 'ci/scripts/install_minio.sh'
      - 'ci/scripts/msys2_*'
      - 'ci/scripts/util_*'
      - 'cpp/**'
      - 'compose.yaml'
      - 'dev/archery/archery/**'
      - 'format/Flight.proto'
      - 'testing'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants