GH-50133: [CI] Make extra labels entirely manual#50256
Open
pitrou wants to merge 1 commit into
Open
Conversation
|
|
Member
Author
Member
Author
|
"Extra: C++" does not seem to be working as expected here? |
raulcd
reviewed
Jun 25, 2026
raulcd
left a comment
Member
There was a problem hiding this comment.
LGTM, as seen on the other issue, should we also avoid forcing a build if the workflow file has changed?
arrow/.github/workflows/check_labels.yml
Lines 74 to 79 in cffe22d
This might force builds when the PR is old and new changes are merged on main.
@kou what do you think on that case?
Member
doesn't it still require changes on the defined path? We could force check on all (remove the paths as we do for cuda_extra.yml) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our "Extra" labels for CI are currently both manual and automatic:
However, the two mechanisms can conflict with each other, when an Extra label is manually added by a committer, but none of the file changes match. The label can then be later removed by the automatic labelling bot.
What changes are included in this PR?
Make the "Extra" labels manual-only.
Are these changes tested?
N/A.
Are there any user-facing changes?
No.