optimize(interleave): implement interleave for FixedSizeList/Map type#10046
Open
mapleFU wants to merge 2 commits into
Open
optimize(interleave): implement interleave for FixedSizeList/Map type#10046mapleFU wants to merge 2 commits into
mapleFU wants to merge 2 commits into
Conversation
mapleFU
commented
Jun 2, 2026
| Ok(Arc::new(list_array)) | ||
| } | ||
|
|
||
| fn interleave_fixed_size_list( |
Member
Author
There was a problem hiding this comment.
This might reusing an optimization with #10025 . Otherwise it might get slower in some case
mapleFU
commented
Jun 2, 2026
| ("list_view<i64>(0.0,0.0,20)", &list_view_i64_no_nulls), | ||
| ("list_view_overlapping<i64>(80x,20)", &list_view_overlapping), | ||
| ("fixed_size_list<i64,5>(0.0,0.0)", &fsl_i64), | ||
| ("fixed_size_list<i64,5>(0.1,0.1)", &fsl_i64_nulls), |
Member
Author
There was a problem hiding this comment.
Maybe I can also support large fsl, like vector<1024, f32>
mapleFU
commented
Jun 2, 2026
Member
Author
There was a problem hiding this comment.
I don't know should I extract benchmark to a separate pr ( containing this and concat benchmark?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Implement interleave for Map/FSL type.
Note: This might a slow implementation for FSL. For map it's a struct type, and at would have two childs. So even if it's
Map<i32, i32>, it wouldn't be slower than before.For FSL, if it's fixed sized list with short i32 list, it may hit the problem in #10025 , making them use same code to handle list is better.
What changes are included in this PR?
Implement interleave for Map/FSL type.
Are these changes tested?
Are there any user-facing changes?
No