Implement Clone for local and memory stores#653
Merged
crepererum merged 1 commit intoapache:mainfrom Mar 11, 2026
Merged
Conversation
These stores already use Arc internally and there is little reason not to provide benefit of Clone similar to cloud stores and enable parity with these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These stores already use Arc internally and there is little reason not to provide benefit of Clone similar to cloud stores and enable parity with these
Which issue does this PR close?
Sorry, no issue, it feels rather minor issue.
Cloud based stores provide
Cloneimpl which meansInMemoryandLocalFileSystemare not good stubbing substitute as they lackCloneimplementationHence this PR adds
Clonederive which will impose clone-ability requirement on these storesWhat changes are included in this PR?
Add
Clonederive onInMemoryandLocalFileSystemstoresAre there any user-facing changes?
No functional changes except adding
CloneontoInMemoryandLocalFileSystem