feat(go/adbc/driver/flightsql): add logging for Flight SQL#4322
Open
davidhcoe wants to merge 7 commits into
Open
feat(go/adbc/driver/flightsql): add logging for Flight SQL#4322davidhcoe wants to merge 7 commits into
davidhcoe wants to merge 7 commits into
Conversation
Contributor
davidhcoe
commented
May 18, 2026
davidhcoe
commented
- Adds Open Telemetry logging for Flight SQL
- Adds support for passing values as parameters to support TOML integration
davidhcoe
commented
May 18, 2026
davidhcoe
commented
May 18, 2026
| // the host process's environment. When neither this option nor the | ||
| // environment variable is set, the driver falls back to the | ||
| // process-global OpenTelemetry tracer provider. | ||
| OptionKeyTelemetryTracesExporter = "adbc.telemetry.traces_exporter" |
Contributor
Author
There was a problem hiding this comment.
This is so we can pass values using the driver manager / TOML values and not need to use environment variables.
zeroshade
requested changes
May 18, 2026
lidavidm
reviewed
May 20, 2026
lidavidm
reviewed
May 29, 2026
added 2 commits
May 30, 2026 23:44
davidhcoe
force-pushed
the
dev/flightsql-logging
branch
from
85d42aa to
7736fd3
Compare
lidavidm
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.