Skip to content

fix: AI chat calls semantic_search and errors out when no VectorSearch plugin is enabled #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hgaol wants to merge 1 commit into
base: dev
Choose a base branch
from
+15 −0
Open

fix: AI chat calls semantic_search and errors out when no VectorSearch plugin is enabled #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/controller/ai_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import (
tagcommonser "github.com/apache/answer/internal/service/tag_common"
usercommon "github.com/apache/answer/internal/service/user_common"
"github.com/apache/answer/pkg/token"
"github.com/apache/answer/plugin"
"github.com/gin-gonic/gin"
"github.com/mark3labs/mcp-go/mcp"
"github.com/sashabaranov/go-openai"
Expand Down Expand Up @@ -672,7 +673,11 @@ func (c *AIController) sendErrorResponse(w http.ResponseWriter, id, model, error
// getMCPTools
func (c *AIController) getMCPTools() []openai.Tool {
openaiTools := make([]openai.Tool, 0)
vectorSearchEnabled := plugin.IsVectorSearchEnabled()
for _, mcpTool := range mcp_tools.MCPToolsList {
if mcpTool.Name == "semantic_search" && !vectorSearchEnabled {
continue
}
openaiTool := c.convertMCPToolToOpenAI(mcpTool)
openaiTools = append(openaiTools, openaiTool)
}
Expand Down
10 changes: 10 additions & 0 deletions plugin/vector_search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,16 @@ var (
registerVectorSearch = MakePlugin[VectorSearch](false)
)

// IsVectorSearchEnabled reports whether at least one VectorSearch plugin is currently enabled.
func IsVectorSearchEnabled() bool {
enabled := false
_ = CallVectorSearch(func(vs VectorSearch) error {
enabled = true
return nil
})
return enabled
}

// GenerateEmbedding is a base utility function that generates an embedding vector
// using an OpenAI-compatible API. Plugins that don't have a built-in vectorizer
// (most vector databases) can call this function with their own credentials.
Expand Down
Loading