Conversation
ARG_LIMIT had no type validation, unlike its siblings ARG_JOB_LIMIT and ARG_NUM_EXECUTIONS, so a non-numeric --limit value crashed deep inside SQLAlchemy's limit-clause coercion with a raw traceback instead of a clean argparse usage error.
The previous fix rejected --limit 0 along with non-numeric and negative values, but 0 was a valid (if unusual) prior invocation -- SQLAlchemy coerced it to LIMIT 0, an intentional "return no records" query, distinct from the undefined behavior of a negative limit.
0 has no documented meaning for this flag, unlike the differently-scoped
ARG_JOB_LIMIT ("0 disables the limit"). Returning zero records isn't a
useful query here -- it's the same "how many things to show" category as
ARG_NUM_EXECUTIONS/ARG_CAPACITY, which also disallow zero.
Also consolidates the invalid-limit regression tests (non-numeric,
negative, zero) into a single parametrized test.
roykoand
commented
Sep 14, 2026
roykoand
marked this pull request as ready for review
September 14, 2026 06:26
roykoand
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
September 14, 2026 06:26
Contributor
Author
|
Well, did not notice the same issue was already surfaced - #72891 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARG_LIMIT(used byairflow dags list-jobs --limit) had notype=validation, unlike its siblingsARG_JOB_LIMITandARG_NUM_EXECUTIONS, which both usetype=positive_int(...). A non-numeric--limitvalue (e.g.airflow dags list-jobs --limit abc) was passed through argparse as a raw string and crashed deep inside SQLAlchemy's limit-clause coercion with an unhandledValueError/traceback, instead of the standard argparse usage error every other typed numeric flag produces.This adds the same
type=positive_int(allow_zero=False)toARG_LIMIT, plus a regression test asserting--limit abcnow exits with argparse's usage-error code (2) instead of crashing.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5) following the guidelines
🤖 Generated with Claude Code