test(task-sdk): add regression tests for xcom_pull default parameter#67274
test(task-sdk): add regression tests for xcom_pull default parameter#67274jlaportebot wants to merge 2 commits into
Conversation
Add comprehensive parametrized tests for xcom_pull returning the user-provided default when no XCom is found, covering single-task, multi-task, and various map_indexes configurations. Also add test verifying None is returned when no default is specified.
|
@jlaportebot A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
The previous commit had broken indentation (1-space instead of proper Python indentation) in both task_runner.py and test_task_runner.py, causing CI static checks and test collection to fail with IndentationError.
|
Thanks for pointing that out, @potiuk. I've pushed a fix for the indentation errors that were causing the static checks to fail (commit 18e127b). The CI workflows seem to be in |
2 participants
Description
Adds comprehensive regression tests for the
xcom_pulldefault parameter fix (see #65673).The existing PR #65673 fixes the bug but lacks test coverage. This PR adds:
xcom_pullreturning the user-provided default when no XCom is foundmap_indexesconfigurationsNoneis returned when no default is specifiedTests
test_xcom_pull_returns_default_when_no_xcom_found— 7 parametrized casestest_xcom_pull_default_none_when_not_specified— verifies backward compatRelated to #65673