Skip to content

Update cncf's import conf path to use common compat SDK#64143

Draft
wjddn279 wants to merge 3 commits intoapache:mainfrom
wjddn279:update-k8s-import-conf
Draft

Update cncf's import conf path to use common compat SDK#64143
wjddn279 wants to merge 3 commits intoapache:mainfrom
wjddn279:update-k8s-import-conf

Conversation

@wjddn279
Copy link
Contributor

related: #60000


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Mar 24, 2026
@jason810496 jason810496 force-pushed the update-k8s-import-conf branch from b27844e to 9346cd5 Compare March 24, 2026 08:57
@potiuk potiuk marked this pull request as draft March 24, 2026 12:09
@potiuk
Copy link
Member

potiuk commented Mar 24, 2026

@wjddn279 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Provider tests: Failing: provider distributions tests / Compat 2.11.1:P3.10:, provider distributions tests / Compat 3.0.6:P3.10:, provider distributions tests / Compat 3.1.8:P3.10:, Non-DB tests: providers / Non-DB-prov::3.10:amazon...google. Run provider tests with breeze run pytest <provider-test-path> -xvs. See Provider tests docs.
  • Kubernetes tests: Failing: Low dep tests: providers / All-prov:LowestDeps:14:3.10:cncf.kubernetes. See the K8s testing documentation. See Kubernetes tests docs.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

@wjddn279 wjddn279 force-pushed the update-k8s-import-conf branch from f899ff3 to 832f278 Compare March 24, 2026 12:49
@wjddn279
Copy link
Contributor Author

@jason810496

Hi Jason. As intended by this PR, I removed the fallback from the existing logic. Currently, the compat tests for the previous version are failing — is that expected? I believe it's because the older version doesn't have the functionality to read from provider_config_fallback_defaults.cfg.

Am I misunderstanding something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants