Clear, Mark Success/Fail and delete multiple Task Instances#64141
Clear, Mark Success/Fail and delete multiple Task Instances#64141shubhamraj-git merged 7 commits intoapache:mainfrom
Conversation
32258e5 to
2512281
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Looks good in my view. As you know I am not a pro in React but tested manually.
One minor, don't know if complex to fix: Adding a not is not setting the note to all tasks being changed e.g. when clearing.
Would be cool to get this into 3.2.0 even if Beta 2 is out - missing this feature every day! We even had one peer today implementing a Dag allowing users to reset tasks by filter as no other UI option possible... (and this Dag uses DB access to clear tasks... but barely missing in 3.x so far!)
30be48f to
1b563f3
Compare
|
@jscheffl The notes are patched. |
There was a problem hiding this comment.
I don't think this is a good approach to make N+1 queries to the backend.
Basically clearing 100 Tis will trigger 100 concurrent db request. That's probably not the best way to handle this.
Did you try this at scale, how does this behave?
This can be a temporary band aid, but will probably need some rework later
|
Marking for 3.2.1. Feature freeze is on for |
|
@pierrejeambrun Yes, this is just a temporary aid to get it working, future PRs will be needed to make it stable. |
closes: #63855
Multi-select TI for the bulk operations such as clear, mark fail/success and delete.
Screenshots -