docs: document secret key names for Helm chart secretName options#64136
Open
Pranaykarvi wants to merge 1 commit intoapache:mainfrom
Open
docs: document secret key names for Helm chart secretName options#64136Pranaykarvi wants to merge 1 commit intoapache:mainfrom
Pranaykarvi wants to merge 1 commit intoapache:mainfrom
Conversation
Pranaykarvi
requested review from
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves inline documentation in
chart/values.yamlfor varioussecretNameoptions, following the existing style ofpgbouncer.configSecretName.Closes #64106
Changes
metadataSecretName— added a sample SQLAlchemy connection string exampleresultBackendSecretName— added a note that it falls back tometadataSecretNameif not set, plus a connection string examplefernetKeySecretName— documented the expected secret key (fernet-key) with an example Secret manifestjwtSecretName— documented the expected secret key (jwt-secret) with an example Secret manifestapiSecretKeySecretName— documented the expected secret key (api-secret-key) with an example Secret manifestwebserverSecretKeySecretName— added deprecation note (useapiSecretKeySecretNamefor Airflow 3+) and example Secret manifestflower.secretName— documented the expected secret key (connection) with an example Secret manifest