Fix DAG run trigger to surface errors instead of swallowing them#64130
Open
dstandish wants to merge 2 commits intoapache:mainfrom
Open
Fix DAG run trigger to surface errors instead of swallowing them#64130dstandish wants to merge 2 commits intoapache:mainfrom
dstandish wants to merge 2 commits intoapache:mainfrom
Conversation
The try/except ValueError block around dag creation wrapped all errors into generic 400 responses, hiding the original exception context from logs and error tracking. Let exceptions propagate naturally so the full traceback is preserved.
dstandish
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Replace broad ValueError with specific ParamValidationError in SerializedParamsDict.validate() so the trigger_dag_run endpoint can catch param validation errors precisely and return 400, while letting unexpected dag run creation errors propagate as 500s.
dstandish
changed the title
pierrejeambrun
approved these changes
Mar 24, 2026
bugraoz93
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trigger_dag_runendpoint had a broadtry/except ValueErroraroundcreate_dagrun()that silently converted anyValueErrorto a 400 response, hiding real errors in server logs.This PR replaces that with targeted handling:
ParamValidationError(already in the SDK) toairflow.exceptionsso core can catch it without importing fromairflow.sdkdirectlySerializedParamsDict.validate()to raiseParamValidationErrorinstead ofValueErrorParamValidationErrorin the endpoint (returning 400), letting all other exceptions fromcreate_dagrun()propagate as 500s so they appear in server logsWas generative AI tooling used to co-author this PR?
Generated-by: Claude Sonnet 4.6 following the guidelines