fix(tflint-installer): Scope regex to avoid release json overmatches#997
fix(tflint-installer): Scope regex to avoid release json overmatches#997RoseSecurity wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughIn Changestflint URL Regex Tightening
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for letting us know that it failed - it's hard to catch all these notifications nowadays. Actually, it's just "regular" GH issues... Other one on the way |
Put an
xinto the box if that apply:Description of your changes
/install/tflint.shby narrowing the TFLint GitHub release URL regex. The previoushttps://.+?...pattern could overmatch GitHub API JSON and pass curl a malformed URL, causing exit code 3. The newhttps://[^\"]*...pattern stops at the JSON string boundary while still matching the linux amd64/arm64 TFLint zip assets.How can we test changes
docker build \ --build-arg INSTALL_ALL=true \ --platform linux/amd64 \ -t pre-commit-terraform:tflint-fix-test .