fix(opencode): stabilize duplicate skill discovery#32203
Open
ualtinok wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
|
3f27d94 to
4e5f471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32202
Type of change
What does this PR do?
Makes duplicate skill discovery deterministic.
The skill catalog already renders sorted by skill name, but duplicate skill names were resolved while loading files with unbounded concurrency. Since duplicate names overwrite the previous entry, whichever file finished loading last won. That made the selected skill
locationunstable across restarts when the same skill name existed in multiple roots.This PR sorts matches within each scan and loads discovered skill files in discovery order, preserving the existing source precedence while removing the I/O race.
How did you verify your code works?
bun test test/skill/skill.test.tsbun typecheckScreenshots / recordings
N/A
Checklist