fix(tui): mark sync complete even when background refresh fails#32180
Open
MethodWhite wants to merge 1 commit into
Open
fix(tui): mark sync complete even when background refresh fails#32180MethodWhite wants to merge 1 commit into
MethodWhite wants to merge 1 commit into
Conversation
The non-blocking Promise.all() in the sync phase had no .catch(), so if any API call failed the sync status stayed 'partial' forever and the rejection went unhandled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24540
Type of change
What does this PR do?
Adds a .catch() to the non-blocking Promise.all() in the sync phase. If any of the 11 API calls fails, the sync status was stuck at "partial" forever. The catch transitions to "complete" so the UI doesn't hang.
How did you verify your code works?
Triggered a network error during the non-blocking sync. Without the fix, the status stays "partial" and an unhandled rejection occurs. With the fix, the status transitions to "complete" and no crash occurs.
Screenshots / recordings
Not a UI change.
Checklist