build: update dependency @web/test-runner-puppeteer to v1#3839
build: update dependency @web/test-runner-puppeteer to v1#3839angular-robot wants to merge 1 commit into
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request updates the @web/test-runner-puppeteer dependency to version ^1.0.0 along with its lockfile. The review feedback recommends upgrading all core @web/test-runner packages to ^1.0.0 simultaneously to prevent version mismatches, potential runtime conflicts, and lockfile bloat.
| "@web/test-runner": "^0.20.2", | ||
| "@web/test-runner-core": "^0.13.4", | ||
| "@web/test-runner-puppeteer": "^0.18.0", | ||
| "@web/test-runner-puppeteer": "^1.0.0", |
There was a problem hiding this comment.
Updating only @web/test-runner-puppeteer to ^1.0.0 while keeping @web/test-runner and @web/test-runner-core on older versions (^0.20.2 and ^0.13.4 respectively) leads to duplicate and mismatched versions of @web/test-runner-core and @web/test-runner-chrome in the dependency tree (as seen in the pnpm-lock.yaml changes). To prevent potential runtime issues, plugin registration conflicts, and bloated lockfiles, all core @web/test-runner packages should be upgraded to ^1.0.0 together.
| "@web/test-runner": "^0.20.2", | |
| "@web/test-runner-core": "^0.13.4", | |
| "@web/test-runner-puppeteer": "^0.18.0", | |
| "@web/test-runner-puppeteer": "^1.0.0", | |
| "@web/test-runner": "^1.0.0", | |
| "@web/test-runner-core": "^1.0.0", | |
| "@web/test-runner-puppeteer": "^1.0.0", |
This PR contains the following updates:
^0.18.0→^1.0.0Release Notes
modernweb-dev/web (@web/test-runner-puppeteer)
v1.0.0Compare Source
Major Changes
5260164: Drop support for Node.js 18 and 20, which have reached end-of-life. The minimum supported Node.js version is now 22.0.0.The Node code is compiled to ES2024 which is aligned with the Node 22.
Patch Changes
5260164]